From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25F532ECEA5 for ; Sun, 7 Dec 2025 12:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765111178; cv=none; b=ZefMPGbSO/Mh6Aty8ARR+eYi4nufPgmiOhCO60T74Cr0t4O35ItmBv/xDGHqtxKxmA5JOrr1SZJ1+IBuGUYLiaOPP4PUq3rbj0GBa5UTX0NHW1pB9DFSEi9+8G/Sjf7eKHz/H64zY0W4+gsQJPE+reymbNy4CzufpXHH9IMV/p8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765111178; c=relaxed/simple; bh=3aC+u0nuPMsrqkVloCDN63ABR3XLIyUV3vUQuLukUCw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=mHYDFYmK1XTC2TvmrZugtg+AxVEyNBfAOnYmqxRPkMTs8keeLF2rgnjO6yGb1PabgtEFFudHS8fqFmx/+c6AGv2SfJ6nA8gEq3aYOFzb+zLUPtyQos51dAT7g1ga2C0qF+hq4GcPJiMXcqoefXyrLq2xfijTvFPpoaB6Bk28OJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fheVurIg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fheVurIg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765111176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=FXlhOdfvxpvaaDvBl5X+h/hsx7G14jGyMV7HWDsiG0A=; b=fheVurIgfq0nub6VjGRBGE984XEe9qiD/MvaMj+61jkfS88uXKe178cROk3JnubMn1Oq6c 2O072zkAGnIfgIfCMFJYrOomwhjJtx67TH8spkzntyzKStxDt176YTz8ht2tXQaORxcxOy M0/JIkHAeiCOQaVuxCa0h1ctwA2nFgE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-MnXhMlg-NOGbLn5AUANwSg-1; Sun, 07 Dec 2025 07:39:29 -0500 X-MC-Unique: MnXhMlg-NOGbLn5AUANwSg-1 X-Mimecast-MFC-AGG-ID: MnXhMlg-NOGbLn5AUANwSg_1765111166 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 543F91956052; Sun, 7 Dec 2025 12:39:26 +0000 (UTC) Received: from fedora (unknown [10.44.32.50]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 7F53119560BD; Sun, 7 Dec 2025 12:39:16 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 7 Dec 2025 13:39:28 +0100 (CET) Date: Sun, 7 Dec 2025 13:39:17 +0100 From: Oleg Nesterov To: Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Felix Kuehling , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Boris Brezillon , Rob Herring , Steven Price , =?iso-8859-1?Q?Adri=E1n?= Larumbe , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Liviu Dudau , Jason Gunthorpe , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 2/7] android/binder: use same_thread_group(proc->tsk, current) in binder_mmap() Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 With or without this change the checked condition can be falsely true if proc->tsk execs, but this is fine: binder_alloc_mmap_handler() checks vma->vm_mm == alloc->mm. Signed-off-by: Oleg Nesterov --- drivers/android/binder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index a00f6678f04d..980bb13228fc 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -6013,7 +6013,7 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma) { struct binder_proc *proc = filp->private_data; - if (proc->tsk != current->group_leader) + if (!same_thread_group(proc->tsk, current)) return -EINVAL; binder_debug(BINDER_DEBUG_OPEN_CLOSE, -- 2.52.0