From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f45.google.com (mail-yx1-f45.google.com [74.125.224.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EE68307AE9 for ; Tue, 9 Dec 2025 19:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765309956; cv=none; b=OiFMHjhs/uWxZKGzYLeZNo00zp8nfaDtoGX4wk4EFF9Z4Db2Nf349xnrKamBtHay+ECxlUabIKPfhvb89Ip8dK2dMCDuKhgyolhnNnZD1xW28hnjE1Ayurlbnt4WO3w/kso4+dFUdS1R056DRYHIWLkjnup84/lYOUet+hGqrEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765309956; c=relaxed/simple; bh=XHL/L/FSKYOnQq3SetiqQKZ3ve52BsUb+UjL14KbL8c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S3mqlUjLooXQ9FONMJIhZhdUFHVcOnAbPg5GQmDS3/SW5ResAHh2j31Zbjt7Ty2qSG0FXBCVtOHDV6IKr0oQ6MBf5MdvRd496WTipxFbxg2qzZLXNWq377oiok3NUewX8Z+k+R/9Tt4NwN41ZZJg86opZlo3wnRkcnr5zzruBO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JYS/YKwB; arc=none smtp.client-ip=74.125.224.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JYS/YKwB" Received: by mail-yx1-f45.google.com with SMTP id 956f58d0204a3-6433f99eb15so5424132d50.3 for ; Tue, 09 Dec 2025 11:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765309953; x=1765914753; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+S3XRmIfY6Nu+N2ZLCSjBdZjpwngwmUECGmLCvjDHC4=; b=JYS/YKwBT9uINGJs0YtoEei+BcWgPlR28O3aqTc7ELWu4ak8jt96qj9N1A6rFEx97y UoKYSu15kAi67xNZxzfPs0wRq0bWRh92qZx9kk+Jgy9tw31yGR3fmzJqAjwg4A4MOX7P 9bL7jbxmonzsi+LHrD7vqtHI1W98N7C8byFw44IVvhL3FBZdJoGQW/pzSoMHW+eGOB9f X+g9AEgJDlsgG1Nz1WhPlCaPKHJTvHM68ooA71V4Gw6wC/FqskNUvUrASYlSq6ek7QQQ zROMwFssQ7rk32CJwEQmETzhC6q1KpDga/wfeAkXudp4GV0SMqOZ2uQZvhD9Fb7CDd7N sydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765309953; x=1765914753; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+S3XRmIfY6Nu+N2ZLCSjBdZjpwngwmUECGmLCvjDHC4=; b=JSzwQLcP8zZuDH8AnKpsjgUy1aH7hynYjSX6QGJA2VNwIqRMvfkFLhTcMmUVzlEaMi LK79t2JwmOL9S0gFF2rUPoUZvafYftBouFxZx8VFlkrNwPgfuVV8VPA3DLBiLSWTimNm Tdm0fqTnu2YzA03OBXhvsYvcc4yNISi26yED6p+lcTf7zhXbBK+0oVeS5Uxr2mbel/1d +nfu+93WhlHuzejoX1ZjTKuenDHimc6QK025HpUzJgzjUjTBQ2+bx0ArfKCzkNK72hRj w5FxkI/OQT6tBgyIFyGCToKFhCsZI3Dtmbu/l6On2wNkuzDavnt0uUatAbdjmF9wnaGv wD4g== X-Gm-Message-State: AOJu0YyvUHH7BBlIcN58AKjkXile6zrHi9tNMMoccrFcdNbeByUBA58C nbYY4iKvjG3dqMU1qq2HhRQCZzJblZKoDG3SrwwMVz4FVVp82NJI0REq X-Gm-Gg: AY/fxX5OBYdlvhZYyTT063QaysBAs8VXCdPWWwzBXo15x/j/+30zPswZyvmSFPOvb4A tEkMZo2nsuvFFHIpE5t9krHqpKGhWSZ3s+mbDG+eiSMmFNV7hrkr47y5p/9+nvuav7SH3XdAU5n Fjimo08E9M+3eZZyT3UXDZjM8MDK6yXouSehAGyR+LyBn/4jkN7Oj2MQ12KudY2bPMNh3abRu6c mug2ojxqb417Y6ir+jUnYqlrv80LP7dbKJrI5fy2c6nvZkG+TMTtA2s8umQm6ANo4Z8WK6ufdFH OW38SmAyeizyyjjM1qa9qgyXR9C+heTkmmjD/3QMTGfcFFzL+rWfCuqJ95fZxr1gthXUuGB2BgB oNGyZd/sI2V9vQlddVMoPnsXivMkbCfShpjsgfnuDtu1puoDtyUvYP4mWLEqkaK+WpPmJg95GpA r5TWewjJAhKtlUC3tD5smqDo4xnAGynVS2y1hG0EDzTGm/GBc= X-Google-Smtp-Source: AGHT+IGVa6r0iFDuAtcL6wIkP8nbDpeCfCQK9vF2pnYiCLEjTySXlHVWrlq2gK/PVPin4gJW60wg5g== X-Received: by 2002:a05:690e:2543:b0:640:d255:2d6f with SMTP id 956f58d0204a3-6446e93f952mr78609d50.34.1765309953244; Tue, 09 Dec 2025 11:52:33 -0800 (PST) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:54::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78c1b4ae638sm63277367b3.4.2025.12.09.11.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 11:52:32 -0800 (PST) Date: Tue, 9 Dec 2025 11:52:31 -0800 From: Bobby Eshleman To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Willem de Bruijn , Neal Cardwell , David Ahern , Arnd Bergmann , Jonathan Corbet , Andrew Lunn , Shuah Khan , Donald Hunter , Mina Almasry Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Bobby Eshleman Subject: Re: [PATCH net-next v7 0/5] net: devmem: improve cpu cost of RX token management Message-ID: References: <20251119-scratch-bobbyeshleman-devmem-tcp-token-upstream-v7-0-1abc8467354c@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251119-scratch-bobbyeshleman-devmem-tcp-token-upstream-v7-0-1abc8467354c@meta.com> On Wed, Nov 19, 2025 at 07:37:07PM -0800, Bobby Eshleman wrote: > This series improves the CPU cost of RX token management by adding an > attribute to NETDEV_CMD_BIND_RX that configures sockets using the > binding to avoid the xarray allocator and instead use a per-binding niov > array and a uref field in niov. > > Improvement is ~13% cpu util per RX user thread. > > Using kperf, the following results were observed: > > Before: > Average RX worker idle %: 13.13, flows 4, test runs 11 > After: > Average RX worker idle %: 26.32, flows 4, test runs 11 > > Two other approaches were tested, but with no improvement. Namely, 1) > using a hashmap for tokens and 2) keeping an xarray of atomic counters > but using RCU so that the hotpath could be mostly lockless. Neither of > these approaches proved better than the simple array in terms of CPU. > > The attribute NETDEV_A_DMABUF_AUTORELEASE is added to toggle the > optimization. It is an optional attribute and defaults to 0 (i.e., > optimization on). > [...] > > Changes in v7: > - use netlink instead of sockopt (Stan) > - restrict system to only one mode, dmabuf bindings can not co-exist > with different modes (Stan) > - use static branching to enforce single system-wide mode (Stan) > - Link to v6: https://lore.kernel.org/r/20251104-scratch-bobbyeshleman-devmem-tcp-token-upstream-v6-0-ea98cf4d40b3@meta.com > Mina, I was wondering if you had any feedback on this approach? Best, Bobby