From: Daniel Golle <daniel@makrotopia.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Rasmus Villemoes <ravi@prevas.dk>,
"Benny (Ying-Tsan) Weng" <yweng@maxlinear.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH net v4 4/4] net: dsa: mxl-gsw1xx: manually clear RANEG bit
Date: Wed, 10 Dec 2025 16:03:30 +0000 [thread overview]
Message-ID: <aTmZynWdLAG__mH2@makrotopia.org> (raw)
In-Reply-To: <20251210155249.bpjm2hkvujstxt4i@skbuf>
On Wed, Dec 10, 2025 at 05:52:49PM +0200, Vladimir Oltean wrote:
> On Tue, Dec 09, 2025 at 01:29:34AM +0000, Daniel Golle wrote:
> > [...]
> > @@ -665,6 +694,9 @@ static void gsw1xx_shutdown(struct mdio_device *mdiodev)
> > dsa_switch_shutdown(priv->ds);
> >
> > dev_set_drvdata(&mdiodev->dev, NULL);
> > +
> > + gsw1xx_priv = container_of(priv, struct gsw1xx_priv, gswip);
> > + cancel_delayed_work_sync(&gsw1xx_priv->clear_raneg);
>
> Nitpick: why did you place this after dev_set_drvdata(dev, NULL) and not before?
> The work item doesn't call dev_get_drvdata(), true, but it's one more refactoring
> step that needs to be taken care of if it should.
As the order of those two doesn't matter I thought the best would be
to do cancel_delayed_work_sync() as the last thing because it is
obviously correct. Eventhough even doing that at all doesn't matter
much in the shutdown() path anyway...
next prev parent reply other threads:[~2025-12-10 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 1:27 [PATCH net v4 0/4] net: dsa: lantiq: a bunch of fixes Daniel Golle
2025-12-09 1:28 ` [PATCH net v4 1/4] net: dsa: lantiq_gswip: fix order in .remove operation Daniel Golle
2025-12-09 1:28 ` [PATCH net v4 2/4] net: dsa: mxl-gsw1xx: " Daniel Golle
2025-12-09 1:29 ` [PATCH net v4 3/4] net: dsa: mxl-gsw1xx: fix .shutdown driver operation Daniel Golle
2025-12-09 1:29 ` [PATCH net v4 4/4] net: dsa: mxl-gsw1xx: manually clear RANEG bit Daniel Golle
2025-12-10 15:52 ` Vladimir Oltean
2025-12-10 16:03 ` Daniel Golle [this message]
2025-12-10 16:16 ` [PATCH net v4 0/4] net: dsa: lantiq: a bunch of fixes Vladimir Oltean
2025-12-16 18:08 ` Daniel Golle
2025-12-16 18:13 ` Vladimir Oltean
2025-12-18 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTmZynWdLAG__mH2@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=ravi@prevas.dk \
--cc=yweng@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).