From: Simon Horman <horms@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] epic100: remove module version and switch to module_pci_driver
Date: Thu, 11 Dec 2025 10:36:50 +0000 [thread overview]
Message-ID: <aTqewtoOZ5s84vEV@horms.kernel.org> (raw)
In-Reply-To: <20251211074922.154268-1-enelsonmoore@gmail.com>
On Wed, Dec 10, 2025 at 11:49:22PM -0800, Ethan Nelson-Moore wrote:
> The module version is useless, and the only thing the epic_init routine
> did besides pci_register_driver was to print the version.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> drivers/net/ethernet/smsc/epic100.c | 35 +----------------------------
Hi Ethan,
Thanks for your patch.
I note that author information is remains present in a comment at the top
of this file. And I agree that not having this kind of information is
current best practice (and has been for quite some time AFAIK). So I think
this patch is a good way to go.
Reviewed-by: Simon Horman <horms@kernel.org>
However, I also think that this is net-next material.
It's best to make that clear by targeting the net-next tree like this.
Subject: [PATCH net-next] ...
It usually isn't necessary to repost a patch just to address this.
But as it happens net-next is currently closed. So I'd like to
ask you to repost this once it re-opens.
## Form letter - net-next-closed
The merge window for v6.19 has begun and therefore net-next has closed
for new drivers, features, code refactoring and optimizations. We are
currently accepting bug fixes only.
Please repost when net-next reopens.
Due to a combination of the merge-window, travel commitments of the
maintainers, and the holiday season, net-next will re-open after
2nd January.
RFC patches sent for review only are welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
next prev parent reply other threads:[~2025-12-11 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 7:49 [PATCH] epic100: remove module version and switch to module_pci_driver Ethan Nelson-Moore
2025-12-11 10:36 ` Simon Horman [this message]
2025-12-12 0:35 ` Francois Romieu
2025-12-11 16:57 ` Sai Krishna Gajula
2025-12-12 0:36 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTqewtoOZ5s84vEV@horms.kernel.org \
--to=horms@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).