From: Simon Horman <horms@kernel.org>
To: Raju Rangoju <Raju.Rangoju@amd.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org,
edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch,
Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH net] amd-xgbe: reset retries and mode on RX adapt failures
Date: Tue, 16 Dec 2025 11:10:39 +0000 [thread overview]
Message-ID: <aUE-L3LsRa4bUn1-@horms.kernel.org> (raw)
In-Reply-To: <20251215151728.311713-1-Raju.Rangoju@amd.com>
On Mon, Dec 15, 2025 at 08:47:28PM +0530, Raju Rangoju wrote:
> During the stress tests, early RX adaptation handshakes can fail, such
> as missing the RX_ADAPT ACK or not receiving a coefficient update before
> block lock is established. Continuing to retry RX adaptation in this
> state is often ineffective if the current mode selection is not viable.
>
> Resetting the RX adaptation retry counter when an RX_ADAPT request fails
> to receive ACK or a coefficient update prior to block lock, and clearing
> mode_set so the next bring-up performs a fresh mode selection rather
> than looping on a likely invalid configuration.
>
> Fixes: 4f3b20bfbb75 ("amd-xgbe: add support for rx-adaptation")
> Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-12-16 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 15:17 [PATCH net] amd-xgbe: reset retries and mode on RX adapt failures Raju Rangoju
2025-12-16 11:10 ` Simon Horman [this message]
2025-12-16 15:00 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUE-L3LsRa4bUn1-@horms.kernel.org \
--to=horms@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).