netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: bestswngs@gmail.com
Cc: security@kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, xmei5@asu.edu
Subject: Re: [PATCH net v4] net: skbuff: add usercopy region to skbuff_fclone_cache
Date: Tue, 16 Dec 2025 11:37:55 +0000	[thread overview]
Message-ID: <aUFEk8QPIAIEHcsF@horms.kernel.org> (raw)
In-Reply-To: <20251216084449.973244-5-bestswngs@gmail.com>

On Tue, Dec 16, 2025 at 04:44:53PM +0800, bestswngs@gmail.com wrote:
> From: Weiming Shi <bestswngs@gmail.com>
> 
> skbuff_fclone_cache was created without defining a usercopy region, [1]
> unlike skbuff_head_cache which properly whitelists the cb[] field.  [2]
> This causes a usercopy BUG() when CONFIG_HARDENED_USERCOPY is enabled
> and the kernel attempts to copy sk_buff.cb data to userspace via
> sock_recv_errqueue() -> put_cmsg().

...

Hi Weiming Shi,

Please slow down.

When posting patches to the Netdev ML please allow 24h to 24h should elapse
between versions. This is to allow time for review. And reduce load on
shared CI infrastructure.

See: https://docs.kernel.org/process/maintainer-netdev.html

Also, I do not believe it is appropriate to involve security@kernel.org
in reports that are made public. As there is nothing left for the security
officers to do.

See:
- https://lore.kernel.org/netdev/CANn89i+3_50FX1RWutvipTMROD3FnK-nBeG4L+br86W85fzRdQ@mail.gmail.com/
- https://www.kernel.org/doc/Documentation/process/security-bugs.rst

Thanks!

  reply	other threads:[~2025-12-16 11:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16  8:44 [PATCH net v4] net: skbuff: add usercopy region to skbuff_fclone_cache bestswngs
2025-12-16 11:37 ` Simon Horman [this message]
2025-12-17 18:24 ` Eric Dumazet
2025-12-23 10:34 ` Paolo Abeni
2025-12-23 10:59   ` Eric Dumazet
     [not found]     ` <ea0174b4-dd9d-40a9-8206-5ae3845a5cab@Canary>
     [not found]       ` <CANn89iK-N9davqJg-BdF9K25T3+oHoabcnyAyrE+8sq1qe-7pQ@mail.gmail.com>
2025-12-23 18:31         ` Weiming Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUFEk8QPIAIEHcsF@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=bestswngs@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=security@kernel.org \
    --cc=xmei5@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).