From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 048C73901F3 for ; Tue, 16 Dec 2025 12:44:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765889064; cv=none; b=HfNxUI+AmZIqAHaBQyutVi2PBy2/9BBqHhPNLPrFHtKS4Zri6rFN8gMnXM5hg3Xn799g5sUc1Nk5yZa3+1xGs+oGOUlqx+cXjSr3FW6ozIb0K2Fj7vFXYRBw3Ac55hOMfrymgyLNiSTEAgGbc9ltah3lZw9x6HrkX/tFE81/i4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765889064; c=relaxed/simple; bh=boIqxM+ov9nSjwgWpy63cnTTzp37ctPMetwDRjr716c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YRe9IbXAkHCp4gpWYB3iN3UUNvOHOLVI5N4IPFH7DwVnqPUKF5tw9G4vF+Rz0/Pvavy+l9V9ypKZDx67CBG3hJGpR0pVYVCpQ9WwnO9evjbRqAnbz4RxGk3+YLu8+TnexxBwzCLWDaDEoBcrtrp+6CpDu7ubUlcoziGLnq5kIvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=DE3BNhOc; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="DE3BNhOc" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso34811855e9.2 for ; Tue, 16 Dec 2025 04:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1765889060; x=1766493860; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/lTD5T6FLVPMFiI1zK6zOO1/qp2X5cLGG7vD5u13cD0=; b=DE3BNhOcc+HNQXvq2D9wHK7NIuewOffYSeXDSlTTjBkaAYU97BUwxMG9Bd17Vj04G0 Udn8He0ZTL2b6WWpup21Pz65uKv9xFnVS7CsZ3CMMxLk4LdE+ORIqEU90QzUCeZoYY3E M93a4SOb9XP+Clv4+mIKU4Mp8YVXMRjFWFsAvF6zu11+Ni4hYptYb8CfRJTJBTud4Nwq C61+N5a2YmlS6bDZ/Ku2Q5wgp/hTUEegwISlmbTHBHBU5TMM+11ijwfMN4CfjDDiL/MH g4UfBRPjvF2wlxN0Xv8vHhKINDlp+zTZpBTb3GZCiCYQBxHLtYr5ITzGE3AKYiitxSzC 1FZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765889060; x=1766493860; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/lTD5T6FLVPMFiI1zK6zOO1/qp2X5cLGG7vD5u13cD0=; b=qOFIxXcpc24nvBqTKcAJktndtlT+2hnzIbtAttLUsLPa7w7PEHGdw1bfTlP2sRfjwY eYVP9NBwYHaBaraBSIzYYj4eaXn7EtVKQ6Iz9i3wEbhaJAL3uxJwZAb90gtbGBURcA8l zWdUlX8OLMAzxDhgNpZT2Z/NiFZXnc3az8ojPLVK5Uy47qLwmbEmjNMyJgtiQ2Mt7RlZ sZ8CAONwxcCS4VBvC9zZDW1vtxyHXuGMk9pDlu+hd8lWR+YINNn/n3pWONa6FRgyHyIY X4mgmY0lxmkKc0xOuudUxqMjIQ6UF+pXtkVWkJ+MhXlCxMzASTnNmNKDrTrGDtYgK9FJ dpeQ== X-Forwarded-Encrypted: i=1; AJvYcCW3n06OQnfvuKdsn3QVQamSWbHYhBoFFh3NM7/sAtXawQEMeEXpZAWgTaguo6hHcGWmVT5pS9U=@vger.kernel.org X-Gm-Message-State: AOJu0YxeN7BfvdcgeiWHjmZMBkjST/ATsb2zO3NFUPlPF9Tex9cXOLrj 4mCNzbnZZca87hzhgf0lwiXN2Jh0nkS+BDyEtSGgNeFiB74eMzEBUSG8Dvalv/v7wYE= X-Gm-Gg: AY/fxX47jnS92gHV1wIFyH486pemVO5iIERfOA/h48S9UiZfr+0EmofjFBcgNbBoqyk G8UtLNgwkvoMMxYYLJV418HvPRUmFUXtLx0Aq6UVTd4whrqGfGfC4jp7q75jhkOlFySHOqbcSu0 seYyIzf1rwcULAlvHOTpOMrlitSl9rceY5FJJmOREjipqOih+TCoLd8SjnLT4bqfYYY6gRkOY11 CbqwqYf+0YC0ZGKXrraxxt95YUsPUiFJ7iB8QlXCzPcfadejEmQK8FoMBxV0yUT3/uxZN+wlohF NIZvaLkm2Q5iXdcLsGn5WcrRcUXjwqFKkRVl/j6Rz5dktSktgdUsHItVnr9Wncp4QqBb5Grx6dQ 6GJMCPAJU4R1kNFuAQ+Thp1W2fBl8dUpukUKFg3IjKmGsd2LF3Df/lAT8wI2GRzhLvh5g9xqwBk 0p6W7sTWgdhir8GQ== X-Google-Smtp-Source: AGHT+IFW5qDickl4JAEFRsGArKDI6FcAB611ceysvy3jNS62BLSz150yvQDh+EMhh7oPcWPJX+4yHw== X-Received: by 2002:a05:600c:3acf:b0:477:1bb6:17de with SMTP id 5b1f17b1804b1-47a8f90f96bmr152908605e9.30.1765889060304; Tue, 16 Dec 2025 04:44:20 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bd95e0161sm9700215e9.2.2025.12.16.04.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 04:44:19 -0800 (PST) Date: Tue, 16 Dec 2025 13:44:17 +0100 From: Petr Mladek To: Joel Granados Cc: Alexander Viro , Christian Brauner , Jan Kara , Muchun Song , Oscar Salvador , David Hildenbrand , Steven Rostedt , John Ogness , Sergey Senozhatsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hams@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] sysctl: Remove unused ctl_table forward declarations Message-ID: References: <20251215-jag-sysctl_fw_decl-v1-1-2a9af78448f8@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251215-jag-sysctl_fw_decl-v1-1-2a9af78448f8@kernel.org> On Mon 2025-12-15 16:25:19, Joel Granados wrote: > Remove superfluous forward declarations of ctl_table from header files > where they are no longer needed. These declarations were left behind > after sysctl code refactoring and cleanup. > > Signed-off-by: Joel Granados For the printk part: Reviewed-by: Petr Mladek That said, I have found one more declaration in kernel/printk/internal.h. It is there because of devkmsg_sysctl_set_loglvl() declaration. But I think that a better solution would be: diff --git a/kernel/printk/internal.h b/kernel/printk/internal.h index dff97321741a..27169fd33231 100644 --- a/kernel/printk/internal.h +++ b/kernel/printk/internal.h @@ -4,9 +4,9 @@ */ #include #include +#include #if defined(CONFIG_PRINTK) && defined(CONFIG_SYSCTL) -struct ctl_table; void __init printk_sysctl_init(void); int devkmsg_sysctl_set_loglvl(const struct ctl_table *table, int write, void *buffer, size_t *lenp, loff_t *ppos); diff --git a/kernel/printk/sysctl.c b/kernel/printk/sysctl.c index bb8fecb3fb05..512f0c692d6a 100644 --- a/kernel/printk/sysctl.c +++ b/kernel/printk/sysctl.c @@ -3,7 +3,6 @@ * sysctl.c: General linux system control interface */ -#include #include #include #include Feel free to add this into v2. Or we could do this in a separate patch. Best Regards, Petr