Re: [PATCH net 1/2] vsock: Make accept()ed sockets use custom setsockopt()

Stefano Garzarella
2025-12-23T10:26:42Z

On Tue, Dec 23, 2025 at 10:15:28AM +0100, Michal Luczaj wrote:
>SO_ZEROCOPY handling in vsock_connectible_setsockopt() does not get called
>on accept()ed sockets due to a missing flag. Flip it.
>
>Fixes: e0718bd82e27 ("vsock: enable setting SO_ZEROCOPY")
>Signed-off-by: Michal Luczaj <mhal@rbox.co>
>---
> net/vmw_vsock/af_vsock.c | 1 +
> 1 file changed, 1 insertion(+)

Thanks for the fix!

>
>diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
>index adcba1b7bf74..c093db8fec2d 100644
>--- a/net/vmw_vsock/af_vsock.c
>+++ b/net/vmw_vsock/af_vsock.c
>@@ -1787,6 +1787,7 @@ static int vsock_accept(struct socket *sock, struct socket *newsock,
> } else {
> newsock->state = SS_CONNECTED;
> sock_graft(connected, newsock);
>+ set_bit(SOCK_CUSTOM_SOCKOPT, &newsock->flags);

I was a bit confused about next lines calling set_bit on
`connected->sk_socket->flags`, but after `sock_graft(connected,
newsock)` they are equivalent.

So, maybe I would move the new line before the sock_graft() call or use
`connected->sk_socket->flags` if you want to keep it after it.

WDYT?

BTW the fix LGTM.
Thanks,
Stefano

> if (vsock_msgzerocopy_allow(vconnected->transport))
> set_bit(SOCK_SUPPORT_ZC,
> &connected->sk_socket->flags);
>
>--
>2.52.0
>