From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DA2740F8CA for ; Thu, 8 Jan 2026 14:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767881520; cv=none; b=OcbQzQ5T1nodG0iE50hqsDfUl/u6dI0QE0iNag63ofkgP6BrdZFrZ0b47QEnHwADacPdChNOh4EnBNRy6jHKpgJ4Acpahid5MFZgyigZpAHK9XOfXHXLOa9Yt99uU8g/YELc8hOFzmSXMbVdPdjncrepBnm/dGCCyXCDNYP9I4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767881520; c=relaxed/simple; bh=AFb8yUemGFVP+E1zn7JOJ8f6bE4z7sRVkT9bi0zm4eY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gYByD3zuv9UPeBCTV4blt/CUXXdm+OHdOMvTiJUQIxCsn8A+8i7nGCL63dVFAwVKBqSzuiM5m5mqdwJccRnmvGjpXRExR1fn+QFLXDI7WrYs6WZhUN47i2Y1EpGrPgNRzKMAV+q29HYxF9CwUgIP8iyf66PEqjrVpPmFqPKBoNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZYspJI45; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ipTnwXHD; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZYspJI45"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ipTnwXHD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767881517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PajL1D9j4AF6hqkkrLXFCZ4j8C7K2WP8fPkzMuDGb9E=; b=ZYspJI45MQXRGPwBNwrGxvfCjkovRKzgFgCIXO04g+MC7fzQ/mRUgXP33W8kcSxODQ03Zc WB2RHv3gQjC5gfPZA5S6UL0jbDykQhTo9QlELw/mQbj6iy8JcV9qge1EXlAM8SCPLHQTZG buFs+XeR97qOt8QZL5+Gs6q5wP0t790= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-FGAUlCr0N8G3Ra1BW31uLw-1; Thu, 08 Jan 2026 09:11:56 -0500 X-MC-Unique: FGAUlCr0N8G3Ra1BW31uLw-1 X-Mimecast-MFC-AGG-ID: FGAUlCr0N8G3Ra1BW31uLw_1767881515 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-64d251b8c5dso3844312a12.1 for ; Thu, 08 Jan 2026 06:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767881515; x=1768486315; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PajL1D9j4AF6hqkkrLXFCZ4j8C7K2WP8fPkzMuDGb9E=; b=ipTnwXHD+dLvDSmgaJopVLl/1O8dnyQsR1tZk+lqtAATXWbvS/P0QG+tojhsdu5HPI pv5SSJgMhShvO/6FGq1gyrxXpQRtHTmRjq3kjiQi9db2f/u50YyurFdq2eA3tMPFMu83 7b8j8EaUsH6N949qWInjMDr7NqkFx/UWgc43C0n1jTdBjSsmOFeiF1PCSICFd/n0TZgm x6dZC343KryZI6rn/qDuvOHK5pI4LEQYtoBQ5GqsLvA1BeDZ2DYxZE+Og3+3EgLCiSOU /aQrIKL82HTc/43aEnyErBjIAbEEsAVicFXAYKgmaOPlK63fvd6vWuHbAo46exB5OpAR 5ghg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767881515; x=1768486315; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PajL1D9j4AF6hqkkrLXFCZ4j8C7K2WP8fPkzMuDGb9E=; b=Zfir1N+EpfF38VK1OtElK+MWXhzSz1Jy5w3HE+NNKz3/vWUQavn+dRlqUAkKc1Ghob NHX2II6UqQUL3RP61cxw//5IijGQphU4pOAG70VpETnPfmGtO9F/qMhysSBqnxZbm9bq lWbVeL8oJW3omx7o6NxDr+sKRemoDZVMj1ALyRO3nRDeHL/+GNSaOW5HQc9a3xIgsshR I9MbmY0/G4CO9l8yLahJ5WD1bq8RbRUoIesnTLhuRtUIWU5FsG9aUGK2Q45S1WPkHBD3 7MbVGrFavNkfqWEv8rxnYflksaypjf0ajot8NZMM8WFpH/vnknEhBKWFpuvZ4yW3B7kJ ObeA== X-Forwarded-Encrypted: i=1; AJvYcCWOoKxmul3cNt6yu0EjR1G6DYwLzF/Bycn/4y/vMBmJ7KPOAZmocJDCyOpIJF8H1LbjAFyqvJ4=@vger.kernel.org X-Gm-Message-State: AOJu0YwjTHVXvNfVi3KvpORHUABRkPHj//czSfUiDA5g7wcD1DHMwHBZ df7K5OdqNv4MJUeeBRC8bw/SbJw0WBh84EFwdDH8B8xpxrsfNmGfrb3fBovoh0TydRjJ2lpG3vt /NBbesd9zJl8igX2RgWThvYtu7d85Hm9bDSDq2v4t32cY+d7mwHKsgnc10w== X-Gm-Gg: AY/fxX7P8p35DEBmuifO86L6KQZcjo9qFCFJvEXBnG1J79KF7a1Bt/ZXsj9s6RLXbcq +DFD4Ww7JZTo2Ke/9Bhpcy/TeEtHtsHW8huovLzn88v0tP3Yf2+co0WkyuHBBl0pJwfj6yEv5/d In7C3GVI8K6WXYr2g/HIrShGZ9f2yyVUOMXs9YsmbqqcJTbj7mXSr92biB11yQrqudEIDTUUEB4 r238QnaYowQE6bPNBFnpF+yv5IN1YAC4mD7Of9O+79TyESeMV4mY9eFI28vY4RjbhIx0adN0F4I racrIyCExEpurd3OKPks+hXFKnGWuUfUtHJEtcaUJpIv8N/7H5vlzODA/zPRt3PiJA5MyUf8OtB E2z5yVj9JDidxkW7T X-Received: by 2002:a05:6402:358c:b0:64d:1bbf:954a with SMTP id 4fb4d7f45d1cf-65097e01237mr6010698a12.15.1767881514764; Thu, 08 Jan 2026 06:11:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFH4GSSsuHOuOKzAWjnLjL93ZyftULQdKpADud0o+HUDbYN/JI+jAlKmTdijyyr2Y36a7d4Rw== X-Received: by 2002:a05:6402:358c:b0:64d:1bbf:954a with SMTP id 4fb4d7f45d1cf-65097e01237mr6010647a12.15.1767881514187; Thu, 08 Jan 2026 06:11:54 -0800 (PST) Received: from sgarzare-redhat ([193.207.223.215]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf65ca0sm7641163a12.24.2026.01.08.06.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:11:53 -0800 (PST) Date: Thu, 8 Jan 2026 15:11:36 +0100 From: Stefano Garzarella To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?utf-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 13/15] vsock/virtio: reorder fields to reduce padding Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Mon, Jan 05, 2026 at 03:23:41AM -0500, Michael S. Tsirkin wrote: >Reorder struct virtio_vsock fields to place the DMA buffer (event_list) >last. This eliminates the padding from aligning the struct size on >ARCH_DMA_MINALIGN. > >Signed-off-by: Michael S. Tsirkin >--- > net/vmw_vsock/virtio_transport.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c >index ef983c36cb66..964d25e11858 100644 >--- a/net/vmw_vsock/virtio_transport.c >+++ b/net/vmw_vsock/virtio_transport.c >@@ -60,9 +60,7 @@ struct virtio_vsock { > */ > struct mutex event_lock; > bool event_run; >- __dma_from_device_group_begin(); >- struct virtio_vsock_event event_list[8]; >- __dma_from_device_group_end(); >+ > u32 guest_cid; > bool seqpacket_allow; > >@@ -76,6 +74,10 @@ struct virtio_vsock { > */ > struct scatterlist *out_sgs[MAX_SKB_FRAGS + 1]; > struct scatterlist out_bufs[MAX_SKB_FRAGS + 1]; >+ IIUC we would like to have these fields always on the bottom of this struct, so would be better to add a comment here to make sure we will not add other fields in the future after this? Maybe we should also add a comment about the `event_lock` requirement we have in the section above. Thanks, Stefano >+ __dma_from_device_group_begin(); >+ struct virtio_vsock_event event_list[8]; >+ __dma_from_device_group_end(); > }; > > static u32 virtio_transport_get_local_cid(void) >-- >MST >