From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 351691D5141; Tue, 6 Jan 2026 22:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767738986; cv=none; b=rKkdYy6rSo5BmI+jejUD0Ar6WtWE9kSA4YoOFf0bqZhdhXgSK1Gp4UzHZjnfRnH89nbfeZjqnHNdFWfktqP3FMgSF+fQS75rGDXLeRvcb1Q4El3SR5SoCkgIb+64JxpBsmwvV4EAicf7CtKzdFQ4xNRclT6Cs3n1fkReFZ5hm5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767738986; c=relaxed/simple; bh=qsmAbwbOihyhUekwomrrbABdRnpkI8wXIYpb1kzmsDM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DeUIqTa9s/C4RVLNUJAr6gEnvB8z1BZ80jbgbkmuAUDIbhDubroRxHyfnqhYC5UW2niblgJe9JIOv/54pxOXum+sAWh6IvVIEJMYwZSA/UObsZxKSROaSfr745SRcq2d/evMUQyZguHMSI4bh/fG6jaiW6elJcmAXnawkaVEIao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vdFev-000000000PJ-3vrN; Tue, 06 Jan 2026 22:36:14 +0000 Date: Tue, 6 Jan 2026 22:36:09 +0000 From: Daniel Golle To: "Russell King (Oracle)" Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Simon Horman , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Wunderlich , Chad Monroe , Cezary Wilmanski , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: Re: [PATCH RFC net-next v4 3/4] net: mdio: add unlocked mdiodev C45 bus accessors Message-ID: References: <36fbca0aaa0ca86450c565190931d987931ab958.1767718090.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 06, 2026 at 05:53:29PM +0000, Russell King (Oracle) wrote: > On Tue, Jan 06, 2026 at 05:14:57PM +0000, Daniel Golle wrote: > > +static inline int __mdiodev_c45_write(struct mdio_device *mdiodev, u32 devad, > > + u16 regnum, u16 val) > > +{ > > + return __mdiobus_c45_write(mdiodev->bus, mdiodev->addr, devad, regnum, > > + val); > > Something doesn't look right here - missing a couple of spaces to > correctly align? I suspect checkpatch would spot it? Somehow those two spaces got dropped somewhere on the way. Strangely neither checkpatch.pl locally nor on patchwork[1] caught that -- maybe because 'return' statements are somehow treated differently? Anyway, fixed in my local tree now and going to be fixed in v5. Are you otherwise fine with adding those unlocked mdiodev c45 helpers? [1]: https://patchwork.kernel.org/project/netdevbpf/patch/36fbca0aaa0ca86450c565190931d987931ab958.1767718090.git.daniel@makrotopia.org/