From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D789F316198 for ; Mon, 5 Jan 2026 12:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767617542; cv=none; b=IdkC4DegEG1321M1/bKpwn7O8SiUeum1dM0M2zNE2tD9E3ztX/hF7w2pkhWnxGHeSXKEuKHQa80degF/oprHjX9vAQIFXfJaDq5Vt6NSXCdGnw+1WdUpRQW72W5cS9PQhaDgTeIzZGUydZL7XOd91tgN86EnvFFCJvohFsXyuvg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767617542; c=relaxed/simple; bh=N0gZejhpVIK3qi+zXOjdBby6xn4BUij6Dyqnfq1/VnA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ns6Yl6VxJbwn7ucnnO1AkRmPGi+u7vG7UK6t+OGyrNg0FrYvbGHp9knEU1r4sIE4ihPFEZVuMCp/SFVIPuZYfD+AuKViGgi+MphBVlbAgCNkCLHyDf5bioe18xxOgUAn9+23xUSQ6pjF1PgGD1N1Z8H/fNKz4U4KWeKU6KHrSdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=3Z0uC/UH; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="3Z0uC/UH" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42fb5810d39so9321387f8f.2 for ; Mon, 05 Jan 2026 04:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1767617538; x=1768222338; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DIfhp3vJVBySXs5/naEXyaaROJC4kEOY5dOC0TJhcN0=; b=3Z0uC/UHBVnzel8Jnhuk8T+cAwex0RTJSiYOheeNpc3vdOwwLJMBAffc5eAvD4KGOL LGK2+inyZLpmTytw/dcj5wps4yJKiNGEqtTVmqt9haYtMuPWkkHivDr4xtyJ+ttb12Ha rfZIWsPp4QYm17CPeymLbjcbS/AZMWvvB9y7ETcw6Pu0WL/DsaXiFxKww8/ccyrmPsvG 86rI/h3UvSFHPf/e2t8new9Nx/gn7C/thk5LZPTN1SdjtNmTmXmoCRCPK4zABE3WLbII W7/0IjShWCirFI6WjQkTMAfwwZfi/GWyYgc7Buz1QSuu2YWxJSaD/AzfupN0+wO6jMeA jaNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767617538; x=1768222338; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DIfhp3vJVBySXs5/naEXyaaROJC4kEOY5dOC0TJhcN0=; b=qnVUbHJ5mkymx2I5VRwNAOHRiKHIZ9DptXAF0B2miZlm4yW9CX5n5L9rtmd/OfT/Fw JGVkZmnT4Tv+jq7/FfI1BW95ZjZUxSLYNffeU4LBKKw0UAar8HVH6cji4/ZqsRut1vdk zOh58deBR6i63s2JBcVR27BJsV4SFdiF6Ry8RlKtrIkSPPdV/JT/bljnI9ZKZr5kqSN5 /GTlSjPHJ7xxtJOfAni8F4mQ+g7r3QfD9QdWpj5uEIWnMX7FKx+9xuBUNGBvFn3dvRgl X1yn8SrjcfECQMjx5CRfgBvCqudPUl52BmMarhkfCwP/sXpjTIFdXv+ivz1NGrxfdZhm Ko4w== X-Forwarded-Encrypted: i=1; AJvYcCU3oYlFxn0YAsMmp6Yy4cjAfi08WYWZq5m1wwhyLIWu8Z4B51IySYhvfKQXSHOXfIhXVYuVoYc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5ZWmCOKG1M9pJ/30+XCkwfnlS951tpTHdiKBKQAy5EKl/1II3 QJa4pxPRysI4V2vGfW+67jyWNJ0YNtf8GggZuZPNI3WSV0Gn5+nXmHYxbx6M0svRPtA= X-Gm-Gg: AY/fxX4bxrw4Z+Xr3rBEpfUPQLCUmUFxA8FDmJVih8XW/TvW0Putbuctu8oEsnkOeBt 8tgIbBiiQVeyv0MVjURCJAvgWNij3v7WAYFTNr0hxTZpqY5bLkL9uzrCSgSdD1Oyl8+KSQuSHLe 4Ime5qZMMXLCRPjiswrMaJgGLJLph51JLZqZxDgQ28ljV7bca45illpB9eAHjWbieP8mYcjjkZU Pq7VhykeooNZoffC6KKZ63mZMEdDhXy6qWMKFudpp3uHhCj5lqO+W2us2U7IGkOigCuCDbOOZZ2 7Rd/BK5Fkj5I9/fi7ZEUfQdiAiV4GARoVhLyd+EbiY5ljXz3hCLFeZgsU7WeNwzIDPb6yx7TN6t pL7l6SHKtMnRsJRjBrr5eo667ILt/2XYumxFvaeP7dOj86iiQsscdz+37dlbpDYBOx3MWjwqoGm O1Dzpso0908wBP1mWYaZxREHZetjr0dG8nYsQ3ki2BRzN3qKM9sI89PJHwjk1COg09OrF9J8s9T O3ftLy/kO63ZSc6PQdz6cuV3hIswgGrZ6AJrxVHV3gMbK35qU1y02sZyEioCWJZPNbTzgF4x91F KSRZdKA= X-Google-Smtp-Source: AGHT+IE4Mz004OZ0As7rWOFq5sPjHYJ4N8Pzam8+bOUXJdXGQOskOlJaecSDta7VRdPfx5XGGjwohQ== X-Received: by 2002:a05:6000:1844:b0:432:8504:b8a9 with SMTP id ffacd0b85a97d-4328504b8e1mr37753933f8f.62.1767617537725; Mon, 05 Jan 2026 04:52:17 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1b36fsm100029761f8f.5.2026.01.05.04.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 04:52:17 -0800 (PST) Date: Mon, 5 Jan 2026 12:52:14 +0000 From: Daniel Thompson To: Marcos Paulo de Souza Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , Greg Kroah-Hartman , Jason Wessel , Daniel Thompson , Douglas Anderson , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Jiri Slaby , Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geert Uytterhoeven , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Andreas Larsson , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Jacky Huang , Shan-Chun Hung , Laurentiu Tudor , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org, netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-hardening@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 00/19] printk cleanup - part 3 Message-ID: References: <20251227-printk-cleanup-part3-v1-0-21a291bcf197@suse.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251227-printk-cleanup-part3-v1-0-21a291bcf197@suse.com> Hi Marcos On Sat, Dec 27, 2025 at 09:16:07AM -0300, Marcos Paulo de Souza wrote: > The parts 1 and 2 can be found here [1] and here[2]. > > The changes proposed in this part 3 are mostly to clarify the usage of > the interfaces for NBCON, and use the printk helpers more broadly. > Besides it, it also introduces a new way to register consoles > and drop thes the CON_ENABLED flag. It seems too much, but in reality > the changes are not complex, and as the title says, it's basically a > cleanup without changing the functional changes. I ran this patchset through the kgdb test suite and I'm afraid it is reporting functional changes. Specifically the earlycon support for kdb has regressed (FWIW the problem bisects down to the final patch in the series where CON_ENABLED is removed). Reproduction on x86-64 KVM outside of the test suite should be easy: make defconfig scripts/config \ --enable DEBUG_INFO \ --enable DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT \ --enable DEBUG_FS \ --enable KALLSYMS_ALL \ --enable MAGIC_SYSRQ \ --enable KGDB \ --enable KGDB_TESTS \ --enable KGDB_KDB \ --enable KDB_KEYBOARD \ --enable LKDTM \ --enable SECURITY_LOCKDOWN_LSM make olddefconfig make -j$(nproc) qemu-system-x86_64 \ -m 1G -smp 2 -nographic \ -kernel arch/x86/boot/bzImage \ -append "console=ttyS0,115200 kgdboc=ttyS0 earlycon=uart8250,io,0x3f8 kgdboc_earlycon kgdbwait" In a successful test the kdb prompt will appear after only a few lines of output: ~~~ [ 0.000000] Linux version 6.19.0-rc4-00020-g4b7f3b144021 (drt@wychelm) (gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44) #2 SMP PREEMPT_DYNAMIC Mon Jan 6 [ 0.000000] Command line: console=ttyS0,115200 kgdboc=ttyS0 earlycon=uart8250,io,0x3f8 kgdboc_earlycon kgdbwait [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable [ 0.000000] BIOS-e820: [mem 0x000000000009fc00-0x000000000009ffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000000f0000-0x00000000000fffff] reserved [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x000000003ffdffff] usable [ 0.000000] BIOS-e820: [mem 0x000000003ffe0000-0x000000003fffffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fffc0000-0x00000000ffffffff] reserved [ 0.000000] BIOS-e820: [mem 0x000000fd00000000-0x000000ffffffffff] reserved [ 0.000000] earlycon: uart8250 at I/O port 0x3f8 (options '') [ 0.000000] printk: legacy bootconsole [uart8250] enabled [ 0.000000] kgdboc: Going to register kgdb with earlycon 'uart' [ 0.000000] KGDB: Registered I/O driver kgdboc_earlycon [ 0.000000] KGDB: Waiting for connection from remote gdb... Entering kdb (current=0x0000000000000000, pid 0) on processor 0 due to NonMaskable Interrupt @ 0xffffffff9101491f [0]kdb> ~~~ After this patchset is applied the earlycon triggers do not work correctly and we get: ~~~ [ 0.000000] Linux version 6.19.0-rc4-00019-g882df99205ba (drt@wychelm) (gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44) #3 SMP PREEMPT_DYNAMIC Mon Jan 6 [ 0.000000] Command line: console=ttyS0,115200 kgdboc=ttyS0 earlycon=uart8250,io,0x3f8 kgdboc_earlycon kgdbwait [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable [ 0.000000] BIOS-e820: [mem 0x000000000009fc00-0x000000000009ffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000000f0000-0x00000000000fffff] reserved [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x000000003ffdffff] usable [ 0.000000] BIOS-e820: [mem 0x000000003ffe0000-0x000000003fffffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fffc0000-0x00000000ffffffff] reserved [ 0.000000] BIOS-e820: [mem 0x000000fd00000000-0x000000ffffffffff] reserved [ 0.000000] earlycon: uart8250 at I/O port 0x3f8 (options '') [ 0.000000] kgdboc: No suitable earlycon yet, will try later ... ~~~ Daniel.