From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Breno Leitao <leitao@debian.org>
Cc: Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, stable@vger.kernel.org
Subject: Re: [PATCH net v2] bnxt_en: Fix NULL pointer crash in bnxt_ptp_enable during error cleanup
Date: Mon, 5 Jan 2026 14:27:16 +0000 [thread overview]
Message-ID: <aVvKRGcSWb1muZ-k@shell.armlinux.org.uk> (raw)
In-Reply-To: <ft63jjhpr2w5s6cdpriixbmmxft5phkvui25pdy46vexpawzz6@mu6gblhm7ofv>
On Mon, Jan 05, 2026 at 06:11:26AM -0800, Breno Leitao wrote:
> Hello Russell,
>
> On Mon, Jan 05, 2026 at 01:29:40PM +0000, Russell King (Oracle) wrote:
> > On Mon, Jan 05, 2026 at 04:00:16AM -0800, Breno Leitao wrote:
> > My guess is that this has something to do with firmware, and maybe
> > upgrading it at runtime - so if the firmware gets upgraded to a
> > version that doesn't support PTP, the driver removes PTP. However,
> > can PTP be used while firmware is being upgraded, and what happens
> > if, e.g. bnxt_ptp_enable() were called mid-upgrade? Would that be
> > safe?
>
> This crash happened at boot time, when the kernel was having another
> at DMA path, which was triggering this bug. There was no firmare upgrade
> at all. Just rebooting the machine with 6.19 was crashing everytime due
> to the early failure to initialize the driver.
Please read my email again. I wasn't questioning _when_ the problem you
were seeing was occuring. I was questioning the overall structural
quality of the driver, suggesting that there are further issues with it
around PTP.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-01-05 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 12:00 [PATCH net v2] bnxt_en: Fix NULL pointer crash in bnxt_ptp_enable during error cleanup Breno Leitao
2026-01-05 13:29 ` Russell King (Oracle)
2026-01-05 14:11 ` Breno Leitao
2026-01-05 14:27 ` Russell King (Oracle) [this message]
2026-01-05 15:51 ` Pavan Chebbi
2026-01-05 17:40 ` Michael Chan
2026-01-05 18:03 ` Russell King (Oracle)
2026-01-05 18:29 ` Michael Chan
2026-01-06 0:04 ` Jakub Kicinski
2026-01-06 11:33 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVvKRGcSWb1muZ-k@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=richardcochran@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox