From: Jiri Olsa <olsajiri@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Menglong Dong <menglong8.dong@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
jiang.biao@linux.dev, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v6 00/10] bpf: fsession support
Date: Tue, 6 Jan 2026 09:54:51 +0100 [thread overview]
Message-ID: <aVzN28i92roV1p4q@krava> (raw)
In-Reply-To: <CAEf4Bza4fD5WWWBxJk0dd_xvgPR0ORZpcp1wiahyMPjvdoWG0w@mail.gmail.com>
On Mon, Jan 05, 2026 at 03:20:13PM -0800, Andrii Nakryiko wrote:
> On Mon, Jan 5, 2026 at 2:33 PM Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> >
> > On Sun, Jan 4, 2026 at 4:28 AM Menglong Dong <menglong8.dong@gmail.com> wrote:
> > >
> > > In current solution, we can't reuse the existing bpf_session_cookie() and
> > > bpf_session_is_return(), as their prototype is different from
> > > bpf_fsession_is_return() and bpf_fsession_cookie(). In
> > > bpf_fsession_cookie(), we need the function argument "void *ctx" to get
> > > the cookie. However, the prototype of bpf_session_cookie() is "void".
> >
> > I think it's ok to change proto to bpf_session_cookie(void *ctx)
> > for kprobe-session. It's not widely used yet, so proto change is ok
> > if it helps to simplify this tramp-session code.
> > I see that you adjust get_kfunc_ptr_arg_type(), so the verifier
> > will enforce PTR_TO_CTX for kprobe and trampoline.
> > Potentially can relax and enforce r1==ctx only for trampoline,
> > but I would do it for both for consistency.
>
> Yeah, I'd support that. It's early enough that this shouldn't be
> breaking a lot of users (if any).
>
> Jiri, do you guys use bpf_session_is_return() or bpf_session_cookie()
> anywhere already?
np, we can still adjust, it's in PR that's not merged yet
jirka
next prev parent reply other threads:[~2026-01-06 8:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 12:28 [PATCH bpf-next v6 00/10] bpf: fsession support Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 01/10] bpf: add " Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 02/10] bpf: use last 8-bits for the nr_args in trampoline Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 03/10] bpf: add the kfunc bpf_fsession_is_return Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 04/10] bpf: add the kfunc bpf_fsession_cookie Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 05/10] bpf,x86: introduce emit_st_r0_imm64() for trampoline Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 06/10] bpf,x86: add fsession support for x86_64 Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 07/10] libbpf: add fsession support Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 08/10] selftests/bpf: add testcases for fsession Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 09/10] selftests/bpf: add testcases for fsession cookie Menglong Dong
2026-01-04 12:28 ` [PATCH bpf-next v6 10/10] selftests/bpf: test fsession mixed with fentry and fexit Menglong Dong
2026-01-05 21:20 ` [PATCH bpf-next v6 00/10] bpf: fsession support Andrii Nakryiko
2026-01-06 3:04 ` Menglong Dong
2026-01-06 4:20 ` Alexei Starovoitov
2026-01-06 7:10 ` Menglong Dong
2026-01-05 22:33 ` Alexei Starovoitov
2026-01-05 23:20 ` Andrii Nakryiko
2026-01-06 8:54 ` Jiri Olsa [this message]
2026-01-06 12:48 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVzN28i92roV1p4q@krava \
--to=olsajiri@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hpa@zytor.com \
--cc=jiang.biao@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=menglong8.dong@gmail.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox