From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: intel-xway: fix OF node refcount leakage
Date: Mon, 19 Jan 2026 14:08:47 +0000 [thread overview]
Message-ID: <aW467-D-2oBzFOY1@makrotopia.org> (raw)
In-Reply-To: <02a2c8a3-3310-4e12-aba2-0dbb3fc780a5@lunn.ch>
On Mon, Jan 19, 2026 at 03:05:54PM +0100, Andrew Lunn wrote:
> On Sun, Jan 18, 2026 at 03:57:04AM +0000, Daniel Golle wrote:
> > Automated review spotted an OF node reference count when checking if the
> > 'leds' child node exists. Call of_put_node() to maintain the refcount.
> >
> > Link: https://netdev-ai.bots.linux.dev/ai-review.html?id=20f173ba-0c64-422b-a663-fea4b4ad01d0
> > Fixes: ("1758af47b98c1 net: phy: intel-xway: add support for PHY LEDs")
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
I guess you meant to put your Reviewed-by: under v2 I've sent yesterday
because this initial submission has a fat-fingered Fixes:-tag...
See
https://patchwork.kernel.org/project/netdevbpf/patch/e3275e1c1cdca7e6426bb9c11f33bd84b8d900c8.1768783208.git.daniel@makrotopia.org/
prev parent reply other threads:[~2026-01-19 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 3:57 [PATCH net] net: phy: intel-xway: fix OF node refcount leakage Daniel Golle
2026-01-19 14:05 ` Andrew Lunn
2026-01-19 14:08 ` Daniel Golle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW467-D-2oBzFOY1@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox