From: Simon Horman <horms@kernel.org>
To: "wanquan.zhong" <zwq2226404116@163.com>
Cc: chandrashekar.devegowda@intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
ricardo.martinez@linux.intel.com, netdev@vger.kernel.org,
loic.poulain@oss.qualcomm.com, ryazanov.s.a@gmail.com,
johannes@sipsolutions.net, davem@davemloft.net,
andrew+netdev@lunn.ch, kuba@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.org,
"wanquan.zhong" <wanquan.zhong@fibocom.com>
Subject: Re: [PATCH] [PATCH v2] wwan: t7xx: Add CONFIG_WWAN_ADB_PORT to control ADB debug port
Date: Mon, 19 Jan 2026 14:15:08 +0000 [thread overview]
Message-ID: <aW48bAZWZr8Bit8x@horms.kernel.org> (raw)
In-Reply-To: <20260114095434.148984-1-zwq2226404116@163.com>
On Wed, Jan 14, 2026 at 05:54:34PM +0800, wanquan.zhong wrote:
> From: "wanquan.zhong" <wanquan.zhong@fibocom.com>
>
> Add a new Kconfig option for MediaTek T7xx WWAN devices, to
> conditionally enable the ADB debug port functionality. This option:
> - Depends on MTK_T7XX (specific to MediaTek T7xx devices)
> - Defaults to 'y', as disabling it may cause difficulties for T7xx
> debugging
> - Requires EXPERT to be visible (to avoid accidental enablement)
>
> In t7xx_port_proxy.c, wrap the ADB port configuration struct with
> CONFIG_WWAN_ADB_PORT, so the port is only exposed when
> the config is explicitly enabled.
>
> This addresses security concerns in certain systems (e.g., Google
> Chrome OS)where root privileges could potentially trigger ADB
> configuration of WWAN devices.Note that only ADB port is restricted
> while MIPC port remains unrestricted,as MIPC is MTK's internal
> protocol port with no security risks.
Hi,
I'm entirely unfamiliar with the security model here.
But is it possible for someone with root privileges to replace
the driver, e.g. to one with ADB enabled?
>
> While using a kernel config option for a single array element in t7xx may
> seem like resource overhead, this is the most straightforward
> implementation approach. Alternative implementation suggestions are
> welcome.
>
> Signed-off-by: wanquan.zhong <wanquan.zhong@fibocom.com>
...
prev parent reply other threads:[~2026-01-19 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 9:54 [PATCH] [PATCH v2] wwan: t7xx: Add CONFIG_WWAN_ADB_PORT to control ADB debug port wanquan.zhong
2026-01-19 14:15 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW48bAZWZr8Bit8x@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=haijun.liu@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=wanquan.zhong@fibocom.com \
--cc=zwq2226404116@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox