From: Yao Zi <me@ziyao.cc>
To: Inochi Amaoto <inochiama@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Richard Cochran <richardcochran@gmail.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Yanteng Si <siyanteng@cqsoftware.com.cn>,
Yao Zi <ziyao@disroot.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Chen-Yu Tsai <wens@kernel.org>,
Shangjuan Wei <weishangjuan@eswincomputing.com>,
Boon Khai Ng <boon.khai.ng@altera.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac
Date: Tue, 20 Jan 2026 10:55:43 +0000 [thread overview]
Message-ID: <aW9fL7r0AM0flALJ@pie> (raw)
In-Reply-To: <20260120043609.910302-2-inochiama@gmail.com>
On Tue, Jan 20, 2026 at 12:36:06PM +0800, Inochi Amaoto wrote:
> The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare
> MAC (version 5.40a) with some extra clock.
>
> Add necessary compatible string for this device.
>
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 3 +
> .../bindings/net/spacemit,k3-dwmac.yaml | 107 ++++++++++++++++++
> 2 files changed, 110 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
...
> diff --git a/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
> new file mode 100644
> index 000000000000..58dd98f79e8a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
...
> + clocks:
> + minItems: 3
> + items:
> + - description: GMAC main clock
> + - description: PTP clock
> + - description: TX clock
> + - description: PHY clock
Why does the MAC require "phy" clock? Shouldn't this be handled in PHY
driver instead, or I get its meaning wrong?
Also, I don't see "phy" clock is acquired anywhere in the driver. Is it
really necessary for the MAC?
Best regards,
Yao Zi
next prev parent reply other threads:[~2026-01-20 10:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 4:36 [PATCH net-next 0/3] riscv: spacemit: Add ethernet support for K3 Inochi Amaoto
2026-01-20 4:36 ` [PATCH net-next 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac Inochi Amaoto
2026-01-20 10:55 ` Yao Zi [this message]
2026-01-20 11:39 ` Inochi Amaoto
2026-01-20 13:48 ` Andrew Lunn
2026-01-20 22:31 ` Inochi Amaoto
2026-01-20 4:36 ` [PATCH net-next 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string Inochi Amaoto
2026-01-20 4:36 ` [PATCH net-next 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Inochi Amaoto
2026-01-20 4:56 ` Russell King (Oracle)
2026-01-20 5:05 ` Inochi Amaoto
2026-01-21 12:03 ` Russell King (Oracle)
2026-01-21 22:36 ` Inochi Amaoto
2026-01-21 23:56 ` Inochi Amaoto
2026-01-20 11:13 ` Yao Zi
2026-01-20 11:28 ` Russell King (Oracle)
2026-01-20 11:43 ` Inochi Amaoto
2026-01-20 11:32 ` Yixun Lan
2026-01-20 11:41 ` Inochi Amaoto
2026-01-20 13:56 ` Andrew Lunn
2026-01-20 22:36 ` Inochi Amaoto
2026-01-21 1:29 ` Andrew Lunn
2026-01-21 1:37 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW9fL7r0AM0flALJ@pie \
--to=me@ziyao.cc \
--cc=alex@ghiti.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=boon.khai.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=looong.bin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=peppe.cavallaro@st.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quentin.schulz@cherry.de \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=siyanteng@cqsoftware.com.cn \
--cc=spacemit@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=weishangjuan@eswincomputing.com \
--cc=wens@kernel.org \
--cc=yong.liang.choong@linux.intel.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox