Re: [PATCH net v2] net: airoha: Fix schedule while atomic in airoha_ppe_deinit()

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

> On Mon, Jan 05, 2026 at 09:43:31AM +0100, Lorenzo Bianconi wrote:
> > airoha_ppe_deinit() runs airoha_npu_ppe_deinit() in atomic context.
> > airoha_npu_ppe_deinit routine allocates ppe_data buffer with GFP_KERNEL
> > flag. Rely on rcu_replace_pointer in airoha_ppe_deinit routine in order
> > to fix schedule while atomic issue in airoha_npu_ppe_deinit() since we
> > do not need atomic context there.
> 
> Hi Lorenzo,

Hi Simon,

> 
> If I understand things correctly the key problem here is that
> an allocation with GFP_KERNEL implies GFP_RECLAIM and thus may sleep.
> But RCU read-side critical sections are not allowed to sleep in non-RT
> kernels.

yes, right, RCU section is atomic.

> 
> If so, I think it would be clearer to describe the problem along those
> lines. But maybe it is just me.

This patch is already in Linus's tree.

Regards,
Lorenzo

> 
> > 
> > Fixes: 00a7678310fe3 ("net: airoha: Introduce flowtable offload support")
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > Changes in v2:
> > - Update commit log.
> > - Link to v1: https://lore.kernel.org/r/20251223-airoha-fw-ethtool-v1-1-1dbd1568c585@kernel.org
> 
> ...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]