From: Simon Horman <horms@kernel.org>
To: Kery Qi <qikeyu2017@gmail.com>
Cc: vburru@marvell.com, netdev@vger.kernel.org, srasheed@marvell.com,
pabeni@redhat.com, sedara@marvell.com, andrew+netdev@lunn.ch,
sburla@marvell.com, kuba@kernel.org, edumazet@google.com
Subject: Re: [PATCH] net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ rollback
Date: Mon, 12 Jan 2026 19:56:56 +0000 [thread overview]
Message-ID: <aWVSCMuX04gdLPL-@horms.kernel.org> (raw)
In-Reply-To: <20260108164256.1749-2-qikeyu2017@gmail.com>
+ Maintainers
On Fri, Jan 09, 2026 at 12:42:57AM +0800, Kery Qi wrote:
> octep_vf_request_irqs() requests MSI-X queue IRQs with dev_id set to
> ioq_vector. If request_irq() fails part-way, the rollback loop calls
> free_irq() with dev_id set to 'oct', which does not match the original
> dev_id and may leave the irqaction registered.
>
> This can keep IRQ handlers alive while ioq_vector is later freed during
> unwind/teardown, leading to a use-after-free or crash when an interrupt
> fires.
>
> Fix the error path to free IRQs with the same ioq_vector dev_id used
> during request_irq().
>
> Fixes: 1cd3b407977c ("octeon_ep_vf: add Tx/Rx processing and interrupt support")
> Signed-off-by: Kery Qi <qikeyu2017@gmail.com>
Thanks, I agree with your analysis; that the problem was introduced
by the cited commit; and the proposed fixes.
Reviewed-by: Simon Horman <horms@kernel.org>
Some notes on procedure For reference, if you post more networking fixes,
or need to spin this patch for some reason.
1. As a bug fix for code present in the net tree it should be
targeted at that tree.
Subject: [PATCH net] ...
2. Please include all maintainers and the patch author of the author commit.
"./scripts/get_maintainer.pl this.patch" can with that.
3. For bug fixes, please consider the guidelines for stable submissions.
I.e. CC; stable@vger.kernel.org
See also: https://docs.kernel.org/process/maintainer-netdev.html
next prev parent reply other threads:[~2026-01-12 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 16:42 [PATCH] net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ rollback Kery Qi
2026-01-12 19:56 ` Simon Horman [this message]
2026-01-12 20:57 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWVSCMuX04gdLPL-@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qikeyu2017@gmail.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox