public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Stefano Garzarella" <sgarzare@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Wei Liu" <wei.liu@kernel.org>,
	"Dexuan Cui" <decui@microsoft.com>,
	"Bryan Tan" <bryan-bt.tan@broadcom.com>,
	"Vishnu Dasa" <vishnu.dasa@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Shuah Khan" <shuah@kernel.org>, "Long Li" <longli@microsoft.com>,
	linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
	netdev@vger.kernel.org, kvm@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org,
	berrange@redhat.com, "Sargun Dhillon" <sargun@sargun.me>,
	"Bobby Eshleman" <bobbyeshleman@meta.com>
Subject: Re: [PATCH RFC net-next v13 03/13] virtio: set skb owner of virtio_transport_reset_no_sock() reply
Date: Mon, 12 Jan 2026 15:21:09 -0800	[thread overview]
Message-ID: <aWWB5bvx677ep317@devvm11784.nha0.facebook.com> (raw)
In-Reply-To: <20260111014500-mutt-send-email-mst@kernel.org>

On Sun, Jan 11, 2026 at 01:46:43AM -0500, Michael S. Tsirkin wrote:
> On Tue, Dec 23, 2025 at 04:28:37PM -0800, Bobby Eshleman wrote:
> > From: Bobby Eshleman <bobbyeshleman@meta.com>
> > 
> > Associate reply packets with the sending socket. When vsock must reply
> > with an RST packet and there exists a sending socket (e.g., for
> > loopback), setting the skb owner to the socket correctly handles
> > reference counting between the skb and sk (i.e., the sk stays alive
> > until the skb is freed).
> > 
> > This allows the net namespace to be used for socket lookups for the
> > duration of the reply skb's lifetime, preventing race conditions between
> > the namespace lifecycle and vsock socket search using the namespace
> > pointer.
> > 
> > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> > Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
> > ---
> > Changes in v11:
> > - move before adding to netns support (Stefano)
> 
> can you explain about the revert please?
> I looked at feedback from Stefano and all he said
> aparently was not to break bisect.

The patch that brings support into vsock_loopback depends on this one to
avoid a introducing a race condition, so it should come before that one.

Best,
Bobby

  reply	other threads:[~2026-01-12 23:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-24  0:28 [PATCH RFC net-next v13 00/13] vsock: add namespace support to vhost-vsock and loopback Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 01/13] vsock: add per-net vsock NS mode state Bobby Eshleman
2026-01-11  6:29   ` Michael S. Tsirkin
2025-12-24  0:28 ` [PATCH RFC net-next v13 02/13] vsock: add netns to vsock core Bobby Eshleman
2026-01-11  6:43   ` Michael S. Tsirkin
2026-01-12 23:34     ` Bobby Eshleman
2026-01-13  0:52       ` Bobby Eshleman
2026-01-13  9:48         ` Stefano Garzarella
2026-01-13 12:34         ` Michael S. Tsirkin
2026-01-13  7:46       ` Michael S. Tsirkin
2025-12-24  0:28 ` [PATCH RFC net-next v13 03/13] virtio: set skb owner of virtio_transport_reset_no_sock() reply Bobby Eshleman
2026-01-11  6:46   ` Michael S. Tsirkin
2026-01-12 23:21     ` Bobby Eshleman [this message]
2025-12-24  0:28 ` [PATCH RFC net-next v13 04/13] vsock: add netns support to virtio transports Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 05/13] selftests/vsock: increase timeout to 1200 Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 06/13] selftests/vsock: add namespace helpers to vmtest.sh Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 07/13] selftests/vsock: prepare vm management helpers for namespaces Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 08/13] selftests/vsock: add vm_dmesg_{warn,oops}_count() helpers Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 09/13] selftests/vsock: use ss to wait for listeners instead of /proc/net Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 10/13] selftests/vsock: add tests for proc sys vsock ns_mode Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 11/13] selftests/vsock: add namespace tests for CID collisions Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 12/13] selftests/vsock: add tests for host <-> vm connectivity with namespaces Bobby Eshleman
2025-12-24  0:28 ` [PATCH RFC net-next v13 13/13] selftests/vsock: add tests for namespace deletion Bobby Eshleman
2026-01-10  0:11 ` [PATCH RFC net-next v13 00/13] vsock: add namespace support to vhost-vsock and loopback Bobby Eshleman
2026-01-11  0:12   ` Michael S. Tsirkin
2026-01-12 17:26     ` Stefano Garzarella
2026-01-12 21:48       ` Bobby Eshleman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWWB5bvx677ep317@devvm11784.nha0.facebook.com \
    --to=bobbyeshleman@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=berrange@redhat.com \
    --cc=bobbyeshleman@meta.com \
    --cc=bryan-bt.tan@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=haiyangz@microsoft.com \
    --cc=horms@kernel.org \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sargun@sargun.me \
    --cc=sgarzare@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=vishnu.dasa@broadcom.com \
    --cc=wei.liu@kernel.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox