Re: [PATCH net-next v3 1/2] dt-bindings: net: airoha: npu: Add BA memory region

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2404 bytes --]

> Introduce Block Ack memory region used by NPU MT7996 (Eagle) offloading.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  .../devicetree/bindings/net/airoha,en7581-npu.yaml  | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)

Hi Rob, Krzysztof and Conor,

Since this patch has been marked as 'needs ack' on patchwork, do you have any
comments on it? Thanks in advance.

Regards,
Lorenzo

> 
> diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> index 59c57f58116b568092446e6cfb7b6bd3f4f47b82..19860b41286fd42f2a5ed15d5dc75ee0eb00a639 100644
> --- a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> +++ b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> @@ -42,14 +42,13 @@ properties:
>        - description: wlan irq line5
>  
>    memory-region:
> -    oneOf:
> -      - items:
> -          - description: NPU firmware binary region
> -      - items:
> -          - description: NPU firmware binary region
> -          - description: NPU wlan offload RX buffers region
> -          - description: NPU wlan offload TX buffers region
> -          - description: NPU wlan offload TX packet identifiers region
> +    items:
> +      - description: NPU firmware binary region
> +      - description: NPU wlan offload RX buffers region
> +      - description: NPU wlan offload TX buffers region
> +      - description: NPU wlan offload TX packet identifiers region
> +      - description: NPU wlan Block Ack buffers region
> +    minItems: 1
>  
>    memory-region-names:
>      items:
> @@ -57,6 +56,8 @@ properties:
>        - const: pkt
>        - const: tx-pkt
>        - const: tx-bufid
> +      - const: ba
> +    minItems: 1
>  
>  required:
>    - compatible
> @@ -93,7 +94,7 @@ examples:
>                       <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
>                       <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
>          memory-region = <&npu_firmware>, <&npu_pkt>, <&npu_txpkt>,
> -                        <&npu_txbufid>;
> -        memory-region-names = "firmware", "pkt", "tx-pkt", "tx-bufid";
> +                        <&npu_txbufid>, <&npu_ba>;
> +        memory-region-names = "firmware", "pkt", "tx-pkt", "tx-bufid", "ba";
>        };
>      };
> 
> -- 
> 2.52.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]