From: Yohei Kojima <yk@y-koj.net>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>, Simon Horman <horms@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] selftests: net: improve error handling in passive TFO test
Date: Tue, 13 Jan 2026 23:22:13 +0900 [thread overview]
Message-ID: <aWZVFRrhENOk_l6z@desktop.y-koj.net> (raw)
In-Reply-To: <88ead962-fec5-4834-88af-c478ee2bf023@web.de>
On Tue, Jan 13, 2026 at 10:46:10AM +0100, Markus Elfring wrote:
> > This commit improves the error handling in passive TFO test to check the
> > return value from … and to fail if read() failed.
>
> Would any developers and system testers like to care more also for data output failures?
> https://elixir.bootlin.com/linux/v6.19-rc4/source/tools/testing/selftests/net/tfo.c#L86-L88
> https://cwe.mitre.org/data/definitions/252.html
That's right. Although we can assume that fprintf() usually succeeds,
it worth checking its return value as tfo_passive.sh relies on the
content of the output.
I posted the v2 series adding fprintf() error handling here:
https://lore.kernel.org/netdev/cover.1768312014.git.yk@y-koj.net/
Thank you,
Yohei
>
> Regards,
> Markus
prev parent reply other threads:[~2026-01-13 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 8:51 [PATCH net-next 0/2] selftests: net: improve error handling in passive TFO test Yohei Kojima
2026-01-12 8:51 ` [PATCH net-next 1/2] selftests: net: fix passive TFO test to fail if child processes failed Yohei Kojima
2026-01-12 8:51 ` [PATCH net-next 2/2] selftests: net: improve error handling in passive TFO test Yohei Kojima
2026-01-12 19:55 ` Markus Elfring
2026-01-13 1:46 ` Yohei Kojima
2026-01-13 9:46 ` Markus Elfring
2026-01-13 14:22 ` Yohei Kojima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWZVFRrhENOk_l6z@desktop.y-koj.net \
--to=yk@y-koj.net \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox