From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 634CF29D27D for ; Tue, 13 Jan 2026 15:44:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768319088; cv=none; b=cvVEhWvT6YCpKhIwSH6bd8Ea3MnZhCF3Y8uhIkDCploYhddEwwI4q9N2+HujdalbB8owKVFNpgyqtmAPcREryAA+ve8JfT1Nnz4O4DiMdP1FsoxzjHfDQ5W1nYAyoi5v3FFwTl86m67A/72EYZdODcnw99QBbKM/1w97PEII7dU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768319088; c=relaxed/simple; bh=JhyhgZnijw5QpfbaydtI94PP620au/36IgAqarY1YUo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GWwEFJTLuco1AehHHpKJUFZJqwsgnpAOEUXQGnHSr8aQT/yqMVZm7/WGkjcmhLNU1gckEws4hUcp/tDeIqTG+rOM4DWVVD3EST9FiVkmFL0Nd8x40dil6RdPi9j7b+qOFAvuYsPRyxY2Sv/omP/qOMFBhYDuqx6Dbvs2oZeEA0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NRmf0DE3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=PiWvd68g; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NRmf0DE3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="PiWvd68g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768319086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L7njAiBZmdfuy2kNwD9BjAHNOOhZ+/EXOjZOWxqIXHU=; b=NRmf0DE3PGccHUCcghfnjAm+gBhkLGAeP/zsT9bNbNQ3xiTUX1dyVCPbCKy+WY51IpM3vW l+HlQ2QqL+cOQGGJJ0pNCpSPd+fl1IRGXgAdJZ9im+UDhqUmSpCCT60aJwNE3BIkRLWDN4 U1uIkaweLrZ++YHMC5XZC6BnCKaUYhs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-MZAO_Rn4MEahXhCPHU36Ng-1; Tue, 13 Jan 2026 10:44:44 -0500 X-MC-Unique: MZAO_Rn4MEahXhCPHU36Ng-1 X-Mimecast-MFC-AGG-ID: MZAO_Rn4MEahXhCPHU36Ng_1768319084 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-477563e531cso53915915e9.1 for ; Tue, 13 Jan 2026 07:44:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768319083; x=1768923883; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L7njAiBZmdfuy2kNwD9BjAHNOOhZ+/EXOjZOWxqIXHU=; b=PiWvd68gfa0m6UBoisTezMckQcjuYjQdc6PRvxiZgVXJZTnsA3r2iZvMOcBF5uJ4Ah Ki4En/71cvoqpmiwxHrXVW+9L3QcEJKB968+o4eOzTgh8HkNClttAHFJGnY7QJjUXx5t XhLnEM6WxuuiaRD1JiXT4e0ySsbJdVNZ18n6j8RGtzBnulaUjUpb0qGzgnOG0mRQ5ndO bil8OQKBbVyeWYoQSCtJjoVe29y8YWbDkNdcQWeB0zwFXZMzbItUhUJVlkWQ4QacEmby yoS+iAHwzoed8eRX3ewEai0eYgb5aQ9Fvqo51zsNjHhxv2ItQKFI7Je2WhZEFX5a081F OdDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768319083; x=1768923883; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L7njAiBZmdfuy2kNwD9BjAHNOOhZ+/EXOjZOWxqIXHU=; b=kt8v3NZrfc+xRcceJEzOXhThKX8sz+Qd4K1GHTxE+ENWU7yJKEUNXhxdl7b/ldeTFr Eq8OOCiJAi0BID7NeEbjdAnKHWH4wmtdw0L/MjEYdWvG0bcAtfKuO+Ye3ajHH9ak08bG ZEpaPhdMYV+jQShPdS3URa8RQ5GpKtB0tyMXq7zgL+s5gX2rBaWYrtvBFuQDIMPxL9RR Hhir6AdIpXTP28O58yXt6WRZhgpigM/Kp72Vqylter661CT1ppgm2KftZit/5K2evSRQ E+mXYLtBktZJ7Df0H7aNXNuKH94ybkNUCllFspfcRMm8GUjc905kCMZFMsPMcZkJlzou eJxQ== X-Forwarded-Encrypted: i=1; AJvYcCXmChZ2xXRKrWAyDzwoI0RZMShByabnHe8sRL2KyrCO3+yUsHHicIgVlhu5C5sDH0+6BG96Ecg=@vger.kernel.org X-Gm-Message-State: AOJu0YzNGv7OlidmPOoQ1uQLqNCsasMyoA01wwoF7PfSJ/PsgKUdJcbU ISPRm0nkD9hzUAzYGRqK3ObFipeDNCW4/mssUQxb04keFIEuHj0uL+F2CwNwY6Q0xnrxt8Yq60C avAVEInNuV+i29ShAynZI70kp3Mw35CrIy7PMEkbz9CHjjG7Qi5E9hHMgAQ== X-Gm-Gg: AY/fxX4kZhZOdN8KS421CMhOvPg7whb6OJ0+f9WJhz0GDuQCNvsPv1u/LLJqTqsRZhE qHsXXlUPfXZcaztcBhxugIdf6Jv+Ww6wRtUoMU9fa+wzDu+3yQZy7mALQWT0sjwWisiRlf0RY1o 6EqZLSUHyT2tiG6uBFBHJTSY+tYC/ADAqpIoiGBMDR3qpzj4jG6W/M0nWvbuDUVc4TnekakBDpY dNjRfuYIhwaJ2rxgPCfeKtVUb+2zu0Uv5gmIxpIsanagHFR38pAc1l93XCAA+I9MlTniMtWRxBK 6qLDIbEPoFszzRBB7C1sOnOZ3h5O2+zrQ5gQTcnC4QJafV6B6Prvy+QcaOPMtxVeJwuDgDXV2lY XchdQkvY405Ms8tbztXglGm8F8Hatyeok026EBOGapFlYM9HorwmjXjS/jMlczA== X-Received: by 2002:a05:600c:4fd0:b0:477:8a2a:1244 with SMTP id 5b1f17b1804b1-47d84b17e75mr251937965e9.11.1768319083551; Tue, 13 Jan 2026 07:44:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGdMqU/UT6yusYgmo7wLLK1QpcbQzRIghkGQravCSZ1TVNgzar9pv/6xyu/8mM8bGjn/QJ4Cg== X-Received: by 2002:a05:600c:4fd0:b0:477:8a2a:1244 with SMTP id 5b1f17b1804b1-47d84b17e75mr251937595e9.11.1768319083140; Tue, 13 Jan 2026 07:44:43 -0800 (PST) Received: from sgarzare-redhat (host-87-12-25-233.business.telecomitalia.it. [87.12.25.233]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f620ac8sm402645575e9.0.2026.01.13.07.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 07:44:42 -0800 (PST) Date: Tue, 13 Jan 2026 16:44:39 +0100 From: Stefano Garzarella To: Bobby Eshleman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Eugenio =?utf-8?B?UMOpcmV6?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan , Long Li , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , Bobby Eshleman Subject: Re: [PATCH net-next v14 05/12] selftests/vsock: add namespace helpers to vmtest.sh Message-ID: References: <20260112-vsock-vmtest-v14-0-a5c332db3e2b@meta.com> <20260112-vsock-vmtest-v14-5-a5c332db3e2b@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260112-vsock-vmtest-v14-5-a5c332db3e2b@meta.com> On Mon, Jan 12, 2026 at 07:11:14PM -0800, Bobby Eshleman wrote: >From: Bobby Eshleman > >Add functions for initializing namespaces with the different vsock NS >modes. Callers can use add_namespaces() and del_namespaces() to create >namespaces global0, global1, local0, and local1. > >The add_namespaces() function initializes global0, local0, etc... with >their respective vsock NS mode by toggling child_ns_mode before creating >the namespace. > >Remove namespaces upon exiting the program in cleanup(). This is >unlikely to be needed for a healthy run, but it is useful for tests that >are manually killed mid-test. > >This patch is in preparation for later namespace tests. > >Signed-off-by: Bobby Eshleman >--- >Changes in v13: >- intialize namespaces to use the child_ns_mode mechanism >- remove setting modes from init_namespaces() function (this function > only sets up the lo device now) >- remove ns_set_mode(ns) because ns_mode is no longer mutable >--- > tools/testing/selftests/vsock/vmtest.sh | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) Reviewed-by: Stefano Garzarella > >diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh >index c7b270dd77a9..c2bdc293b94c 100755 >--- a/tools/testing/selftests/vsock/vmtest.sh >+++ b/tools/testing/selftests/vsock/vmtest.sh >@@ -49,6 +49,7 @@ readonly TEST_DESCS=( > ) > > readonly USE_SHARED_VM=(vm_server_host_client vm_client_host_server vm_loopback) >+readonly NS_MODES=("local" "global") > > VERBOSE=0 > >@@ -103,6 +104,36 @@ check_result() { > fi > } > >+add_namespaces() { >+ local orig_mode >+ orig_mode=$(cat /proc/sys/net/vsock/child_ns_mode) >+ >+ for mode in "${NS_MODES[@]}"; do >+ echo "${mode}" > /proc/sys/net/vsock/child_ns_mode >+ ip netns add "${mode}0" 2>/dev/null >+ ip netns add "${mode}1" 2>/dev/null >+ done >+ >+ echo "${orig_mode}" > /proc/sys/net/vsock/child_ns_mode >+} >+ >+init_namespaces() { >+ for mode in "${NS_MODES[@]}"; do >+ # we need lo for qemu port forwarding >+ ip netns exec "${mode}0" ip link set dev lo up >+ ip netns exec "${mode}1" ip link set dev lo up >+ done >+} >+ >+del_namespaces() { >+ for mode in "${NS_MODES[@]}"; do >+ ip netns del "${mode}0" &>/dev/null >+ ip netns del "${mode}1" &>/dev/null >+ log_host "removed ns ${mode}0" >+ log_host "removed ns ${mode}1" >+ done >+} >+ > vm_ssh() { > ssh -q -o UserKnownHostsFile=/dev/null -p ${SSH_HOST_PORT} localhost "$@" > return $? >@@ -110,6 +141,7 @@ vm_ssh() { > > cleanup() { > terminate_pidfiles "${!PIDFILES[@]}" >+ del_namespaces > } > > check_args() { > >-- >2.47.3 >