From: Guillaume Nault <gnault@redhat.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org,
syzbot+2c42ea4485b29beb0643@syzkaller.appspotmail.com
Subject: Re: [PATCH v1 net] l2tp: Fix memleak in l2tp_udp_encap_recv().
Date: Tue, 13 Jan 2026 20:13:58 +0100 [thread overview]
Message-ID: <aWaZdj7VcRCOK869@debian> (raw)
In-Reply-To: <20260113185446.2533333-1-kuniyu@google.com>
On Tue, Jan 13, 2026 at 06:54:44PM +0000, Kuniyuki Iwashima wrote:
> syzbot reported memleak of struct l2tp_session, l2tp_tunnel,
> sock, etc. [0]
>
> The cited commit moved down the validation of the protocol
> version in l2tp_udp_encap_recv().
>
> The new place requires an extra error handling to avoid the
> memleak.
>
> Let's call l2tp_session_put() there.
Reviewed-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2026-01-13 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 18:54 [PATCH v1 net] l2tp: Fix memleak in l2tp_udp_encap_recv() Kuniyuki Iwashima
2026-01-13 19:13 ` Guillaume Nault [this message]
2026-01-16 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWaZdj7VcRCOK869@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=syzbot+2c42ea4485b29beb0643@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox