From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E33C36BCE4 for ; Wed, 14 Jan 2026 10:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768385876; cv=none; b=unLD5apQVbjQoBC12FY7ORi9YJMNU2/yAj08ye9840EQrbkDGL8w+3iclUjZJ0zSwwGAqE7MhZlZ9LYdkRIkQYxrrpL3BQkdjA5ar9+u2KVAVsk+T1zjOgAAP2OQIN18VgHPuDu9/oTjmYesM6GzkWK2rYhKvmuCKNHsabkzmrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768385876; c=relaxed/simple; bh=QqkDEFk5dyPKAN8J1Ws7pi1hlPYnkNwaLkrtUjgQAis=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q3V0vP7EvBi8s4EkATDqQvb3HXH0uUucVpy3OGceYx/1zW+yEKjYJ72Nohz2oYJ0ySEUmavnZCOXE1w73vMuiAmhA7BrXydUD9dtpn/opgwViUCKgM/AeL1Tgy6GzJEoIWKggr5UTxGeqdCsV2NFD0q9+ABLj1FOpha29FifYQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vfxwi-0001Za-V2; Wed, 14 Jan 2026 11:17:48 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfxwh-000ZXO-2x; Wed, 14 Jan 2026 11:17:47 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vfxwh-00Bgx4-0Q; Wed, 14 Jan 2026 11:17:47 +0100 Date: Wed, 14 Jan 2026 11:17:47 +0100 From: Oleksij Rempel To: Tetsuo Handa Cc: Robin van der Gracht , kernel@pengutronix.de, Oliver Hartkopp , Marc Kleine-Budde , linux-can@vger.kernel.org, Network Development Subject: Re: [PATCH] can: j1939: deactivate session upon receiving the second rts Message-ID: References: <4b1fbe9d-5ca2-41e9-b252-1304cc7c215a@I-love.SAKURA.ne.jp> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org On Wed, Jan 14, 2026 at 12:28:47AM +0900, Tetsuo Handa wrote: > Since j1939_session_deactivate_activate_next() in j1939_tp_rxtimer() is > called only when the timer is enabled, we need to call > j1939_session_deactivate_activate_next() if we cancelled the timer. > Otherwise, refcount for j1939_session leaks, which will later appear as > > unregister_netdevice: waiting for vcan0 to become free. Usage count = 2. > > problem. > > Reported-by: syzbot > Closes: https://syzkaller.appspot.com/bug?extid=881d65229ca4f9ae8c84 > Signed-off-by: Tetsuo Handa Tested-by: Oleksij Rempel Acked-by: Oleksij Rempel Thank you! Best Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |