From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C37337F73F; Wed, 14 Jan 2026 10:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768387178; cv=none; b=qUTR9jJPkNMZ9CTftiAZNuRbiPLzmwJ/IRzUGdGrsJ5Bw2Z/ggMQNDl6COx0WHBKgg+73Zq2Uy4zXwMEI5TovmhFAFS2OmCew+e7UFgQ17jBZed0kYINo8f5vBuXHOmZsQSqZ5azPN1vCOyr/jGttmgVv+JqAwK1XFMV5910hnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768387178; c=relaxed/simple; bh=PmtSOXi6c4cRmNhidQU2+wsF/W2ejrabkd2m859hO1o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZqYj47ViatPJNr/WY2ReRbvJoaZ8eRgzh4yQwSBBJx/wNTbeG73t+JGRy6Qi7vs3CHEKEQ/Zt4Gd/YpILBvHErzP3lg9fHrv6Re94IU7CxAszwOfQ+nnsxEAxFhV1q27V9vx5GHKy+ZY/gg9xpoIU9zJn3yQ0PENHNJt1HyonDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c8pZQAuS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c8pZQAuS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DC50C4CEF7; Wed, 14 Jan 2026 10:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768387178; bh=PmtSOXi6c4cRmNhidQU2+wsF/W2ejrabkd2m859hO1o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c8pZQAuS2x+DXrlRtx6UwoyXR/7RcnDqc3NIUxC3bJJQp/I59re4L7a4VfC353p/Z ANP0uWXeEAITH/OKD+02Umq+QCuxKGRd7m4UscqVRRfYAPW3OMKlhulQ3FOldAV8Y7 FYlizb5GwrhY8WGovPnPKLsjWO1JOSBwPK3nh+GUDhcBg7Zf5qcex+Z6+7ivQzwqy4 g5hWUPcLLZAEvnAeAi+OqarPuVV9enHrv42DGTE5xF/nrLN/koni2ttoGDaSoAMW+z tz/rNkcurxIfq9f/7q1za4joCdHKfXWWB+DJiB/9hamV7HHrKn4T+7Zj3wXLHieD5y 4l/gk0KpiG0cA== Date: Wed, 14 Jan 2026 11:39:35 +0100 From: Lorenzo Bianconi To: Krzysztof Kozlowski Cc: Christian Marangi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: airoha: npu: Add EN7581-7996 support Message-ID: References: <20260113-airoha-npu-firmware-name-v2-0-28cb3d230206@kernel.org> <20260113-airoha-npu-firmware-name-v2-1-28cb3d230206@kernel.org> <20260114-heretic-optimal-seahorse-bb094d@quoll> <75f9d8c9-20a9-4b7e-a41c-8a17c8288550@kernel.org> <69676b6c.050a0220.5afb9.88e4@mx.google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i+i1tfo+9kenP0X6" Content-Disposition: inline In-Reply-To: --i+i1tfo+9kenP0X6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jan 14, Krzysztof Kozlowski wrote: > On 14/01/2026 11:09, Christian Marangi wrote: > > On Wed, Jan 14, 2026 at 10:26:33AM +0100, Krzysztof Kozlowski wrote: > >> On 14/01/2026 10:01, Lorenzo Bianconi wrote: > >>>> On Tue, Jan 13, 2026 at 09:20:27AM +0100, Lorenzo Bianconi wrote: > >>>>> Introduce en7581-npu-7996 compatible string in order to enable MT76= NPU > >>>>> offloading for MT7996 (Eagle) chipset since it requires different > >>>>> binaries with respect to the ones used for MT7992 on the EN7581 SoC. > >>>>> > >>>>> Signed-off-by: Lorenzo Bianconi > >>>>> --- > >>>>> Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml | 1 + > >>>>> 1 file changed, 1 insertion(+) > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-np= u.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml > >>>>> index 59c57f58116b568092446e6cfb7b6bd3f4f47b82..96b2525527c14f60754= 885c1362b9603349a6353 100644 > >>>>> --- a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml > >>>>> +++ b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml > >>>>> @@ -18,6 +18,7 @@ properties: > >>>>> compatible: > >>>>> enum: > >>>>> - airoha,en7581-npu > >>>>> + - airoha,en7581-npu-7996 > >>>> > >>>> This does not warrant new compatible. There is some misunderstanding= and > >>>> previous discussion asked you to use proper compatible, not invent f= ake > >>>> one for non-existing hardware. Either you have en7996-npu or > >>>> en7581-npu. Not some mixture. > >>> > >>> Hi Krzysztof, > >>> > >>> We need to specify which fw binaries the airoha NPU module should load > >>> according to the MT76 WiFi chipset is running on the board (since the= NPU > >>> firmware images are not the same for all the different WiFi chipsets). > >>> We have two possible combinations: > >>> - EN7581 NPU + MT7996 (Eagle) > >>> - EN7581 NPU + MT7992 (Kite) > >>> > >>> Please note the airoha NPU module is always the same (this is why is = just > >>> added the -7996 suffix in the compatible string). IIUC you are sugges= ting > >>> to use the 'airoha,en7996-npu' compatible string, right? > >> > >> No. I am suggesting you need to describe here the hardware. You said > >> this EN7581 NPU, so this is the only compatible you get, unless (which > >> is not explained anywhere here) that's part of MT799x soc, but then you > >> miss that compatible. Really, standard compatible rules apply - so > >> either this is SoC element/component or dedicated chip. > >> > >> > >=20 > > Hi Krzysztof, > >=20 > > just noticing this conversation and I think there is some confusion > > here. > >=20 > > The HW is the following: > >=20 > > AN/EN7581 SoC that have embedded this NPU (a network coprocessor) that > > require a dedicated firmware blob to be loaded to work. > >=20 > > Then the SoC can have various WiFi card connected to the PCIe slot. > >=20 > > For the WiFi card MT7996 (Eagle) and the WiFi card MT7992 (Kite) the NPU > > can also offload the WiFi traffic. > >=20 > > A dedicated firmware blob for the NPU is needed to support the specific > > WiFi card. > >=20 > > This is why v1 proposed the implementation with the firmware-names > > property. > >=20 > > v2 introduce the compatible but I feel that doesn't strictly describe > > the hardware as the NPU isn't specific to the WiFi card but just the > > firmware blob. > >=20 > >=20 > > I still feel v1 with firmware-names should be the correct candidate to > > handle this. >=20 > Yes. What you plug into PCI is not a part of this hardware, so cannot be > part of the compatible. ack. So is it fine to use firmware-name property in this case as proposed in v1? Regards, Lorenzo >=20 > >=20 > > Hope now the HW setup is more clear. > >=20 >=20 >=20 > Best regards, > Krzysztof --i+i1tfo+9kenP0X6 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaWdyZwAKCRA6cBh0uS2t rNG6AP9ZgXi9DzZ/J5WNCHk+rSJoJ3WG0/Jl1sK+NvANqgO8RwEAvtrzXIcDbTBW axwTAak1fGU7QeE8dCYpEpRPA5aQNQA= =6lmW -----END PGP SIGNATURE----- --i+i1tfo+9kenP0X6--