public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] tools/net/ynl: Makefile's install target now installs ynltool
@ 2026-01-15 21:23 Michel Lind
  2026-01-16 10:58 ` Michel Lind
  0 siblings, 1 reply; 2+ messages in thread
From: Michel Lind @ 2026-01-15 21:23 UTC (permalink / raw)
  To: netdev; +Cc: Jakub Kicinski

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

This tool is built by default, but was not being installed by default
when running `make install`. Fix this; it installs to $(prefix)/bin by
default unless bindir is overridden.

Signed-off-by: Michel Lind <michel@michel-slm.name>
---
 tools/net/ynl/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/net/ynl/Makefile b/tools/net/ynl/Makefile
index c2f3e8b3f2ac..bf3f8b16170d 100644
--- a/tools/net/ynl/Makefile
+++ b/tools/net/ynl/Makefile
@@ -4,6 +4,7 @@ include ../../scripts/Makefile.arch
 
 INSTALL	?= install
 prefix  ?= /usr
+bindir  ?= $(prefix)/bin
 ifeq ($(LP64), 1)
   libdir_relative = lib64
 else
@@ -41,13 +42,16 @@ clean distclean:
 	rm -rf pyynl.egg-info
 	rm -rf build
 
-install: libynl.a lib/*.h
+install: libynl.a lib/*.h ynltool
 	@echo -e "\tINSTALL libynl.a"
 	@$(INSTALL) -d $(DESTDIR)$(libdir)
 	@$(INSTALL) -m 0644 libynl.a $(DESTDIR)$(libdir)/libynl.a
 	@echo -e "\tINSTALL libynl headers"
 	@$(INSTALL) -d $(DESTDIR)$(includedir)/ynl
 	@$(INSTALL) -m 0644 lib/*.h $(DESTDIR)$(includedir)/ynl/
+	@echo -e "\tINSTALL ynltool"
+	@$(INSTALL) -d $(DESTDIR)$(bindir)
+	@$(INSTALL) -m 0755 ynltool/ynltool $(DESTDIR)$(bindir)/
 	@echo -e "\tINSTALL pyynl"
 	@pip install --prefix=$(DESTDIR)$(prefix) .
 	@make -C generated install
-- 
2.52.0


-- 
 _o) Michel Lind
_( ) identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
     README:     https://fedoraproject.org/wiki/User:Salimma#README

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] tools/net/ynl: Makefile's install target now installs ynltool
  2026-01-15 21:23 [PATCH net] tools/net/ynl: Makefile's install target now installs ynltool Michel Lind
@ 2026-01-16 10:58 ` Michel Lind
  0 siblings, 0 replies; 2+ messages in thread
From: Michel Lind @ 2026-01-16 10:58 UTC (permalink / raw)
  To: netdev; +Cc: Jakub Kicinski

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

On Thu, 2026-01-15 at 21:23 +0000, Michel Lind wrote:
> This tool is built by default, but was not being installed by default
> when running `make install`. Fix this; it installs to $(prefix)/bin
> by
> default unless bindir is overridden.
> 
Jakub pointed out ynltool has its own Makefile already, and it turns
out it even has an `install` target. Per the process documentation I'll
wait until 24 hours have passed, and then post a v2 that just delegates
to this; it works fine when tested on a local build for CentOS
Hyperscale.

Best regards,

-- 
 _o) Michel Lind
_( ) https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
     README:    https://fedoraproject.org/wiki/User:Salimma#README

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-16 10:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 21:23 [PATCH net] tools/net/ynl: Makefile's install target now installs ynltool Michel Lind
2026-01-16 10:58 ` Michel Lind

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox