From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86CFD31B824; Fri, 16 Jan 2026 09:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768554658; cv=none; b=LbK4QlEGUZKPiYw/pXJz83AtX7yj0fyhwFoYEb4gSHLtvQ5VB3vJdiL9dsH+R425i8x4ji1V57G0Qm3Q/0sf8GNjauXp2ZNU9ypt+tDLFBaSq28NuoiSl86Y7Q2HXUbhPijrTBYnbNvEvv1KB9bJuxaFUDZdOju+XDfRNf+9En8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768554658; c=relaxed/simple; bh=stl7/CP6JCG8jmbUK6mwEvwFy7pTD9LimJyd3DE5WK4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YhJ3TpzsOxsDufpPU6HK7c1ry8g1FnwJdNbU54JVy0oYTnB7E4Xmc8d/raXe2IXdSajIQobFmGp5eNEMqUBshI1T0TKedZP1Wrocn97SwDlfUlkSwYplUlOK4xqbrq+lx6itSYBcCAV8gkluCC74qR/IaMH86JRX1a3Xr5jH57A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VKmdBb+x; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VKmdBb+x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A132AC116C6; Fri, 16 Jan 2026 09:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768554658; bh=stl7/CP6JCG8jmbUK6mwEvwFy7pTD9LimJyd3DE5WK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VKmdBb+xW2DBTd1gCyEX7u7xUcH5iyamHBGpxfFcrRWccPBBsfy034lA7Flp4bBOb wDSVYwcAyyFxuFPj45/yQNZst5ASyYLQL+SKXvt1NWn0LV/GROec4Fj/t6tEZnJFBK 0CEfZJJmYCavgDaQ/bNZGXNKsL6u4oW80rq6XXHLfJcZwgvT2m2zDg93RG65h5p/1L ELBSm1zkXf0C9opNnVV28BrPrIALB9WVR6YsJ0eXBLBCf88euyRXFa1l70tvbr6d9i pNPwqjTI67n5FIO36k3dlW9AfvHIC6u4JIMnvgMKJ3EZFPSxCadIJdw+6svPBKjE0v KNPEeQ1DNHaKQ== Date: Fri, 16 Jan 2026 10:10:55 +0100 From: Lorenzo Bianconi To: Andrew Lunn Cc: Christian Marangi , Krzysztof Kozlowski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: airoha: npu: Add EN7581-7996 support Message-ID: References: <69676b6c.050a0220.5afb9.88e4@mx.google.com> <69677256.5d0a0220.2dc5a5.fad0@mx.google.com> <76bbffa8-e830-4d02-a676-b494616568a2@lunn.ch> <6967c46a.5d0a0220.1ba90b.393c@mx.google.com> <9340a82a-bae8-4ef6-9484-3d2842cf34aa@lunn.ch> <13947d52-b50d-425e-b06d-772242c75153@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GrcIY/mecD2UcAwp" Content-Disposition: inline In-Reply-To: <13947d52-b50d-425e-b06d-772242c75153@lunn.ch> --GrcIY/mecD2UcAwp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Wed, Jan 14, 2026 at 11:35:10PM +0100, Lorenzo Bianconi wrote: > > > > In the current codebase the NPU driver does not need to access the = WiFi PCIe > > > > slot (or any other external device) since the offloading (wired and= wireless) > > > > is fully managed by the NPU chip (hw + firmware binaries). > > >=20 > > > Are you saying the NPU itself enumerates the PCI busses and finds the > > > WiFi device? If it can do that, why not ask it which PCI device it is > > > using? > >=20 > > nope, we do not need any PCI enumeration in the NPU driver at the moment > > (please see below). > >=20 > > >=20 > > > Or this the PCI slot to use somehow embedded within the firmware? > >=20 > > in the current implementation the NPU driver does not need any referenc= e to > > WiFi or Ethernet devices. The NPU exports offloading APIs to consumer d= evices > > (e.g. WiFi or Ethernet devices). In particular, > > 1- during NPU module probe, the NPU driver configures NPU hw registers = and > > loads the NPU firmware binaries. > > 2- NPU consumers (ethernet and/or wifi devices) get a reference to the = NPU > > device via device-tree in order to consume NPU APIs for offloading. > > 3- netfilter flowtable offloads traffic to the selected ethernet and/or= WiFi > > device that runs the NPU APIs accessible via the NPU reference obtai= ned via > > dts. > >=20 > > The issue here is the NPU firmware binaries for EN7581, loaded by the N= PU > > driver during NPU probe and used for offloading, depend on the WiFi chi= pset > > (e.g. MT7996 or MT7992) available on the EN7581 board (we have two diff= erent > > NPU binaries for MT7996 offloading and for MT7992 offloading). >=20 > Maybe i'm getting the NPU wrong, but i assumed it was directly talking > to the Ethernet and WiFi device on the PCIe bus, bypassing the host? correct > If so, it most somehow know what PCIe slots these devices use? I have low visibility on the NPU hw internals but I do not think there are any registers in NPU mmio memory where we can read this info, but I will confirm it (please remember the fw binaries are not load yet). Regards, Lorenzo >=20 > Andrew --GrcIY/mecD2UcAwp Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaWoAnwAKCRA6cBh0uS2t rAv4AQDILUAs5QRGF9kT+2W49Tk8wLiz1kdJI3O1IJdVlVFzPAEAuUAKHZtMDk/P Gu6U2I5rbMpy7HAsiTWVDUCCX5uN3wQ= =UTz0 -----END PGP SIGNATURE----- --GrcIY/mecD2UcAwp--