[PATCH iwl-net] idpf: Fix flow rule delete failure due to invalid validation

[PATCH iwl-net] idpf: Fix flow rule delete failure due to invalid validation

[Sreedevi Joshi]

When deleting a flow rule using "ethtool -N <dev> delete <location>",
idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even
though ethtool doesn't populate this field for delete operations. The
uninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or
RX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate
rule deletions. Remove the unnecessary sideband action enable check and
ring_cookie validation during delete operations since action validation
is not required when removing existing rules.

Fixes: ada3e24b84a0 ("idpf: add flow steering support")
Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
---
 drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
index 2efa3c08aba5..49cefb973f4d 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
@@ -307,9 +307,6 @@ static int idpf_del_flow_steer(struct net_device *netdev,
 	vport_config = vport->adapter->vport_config[np->vport_idx];
 	user_config = &vport_config->user_config;
 
-	if (!idpf_sideband_action_ena(vport, fsp))
-		return -EOPNOTSUPP;
-
 	rule = kzalloc(struct_size(rule, rule_info, 1), GFP_KERNEL);
 	if (!rule)
 		return -ENOMEM;
-- 
2.25.1

Re: [PATCH iwl-net] idpf: Fix flow rule delete failure due to invalid validation

[Simon Horman]

On Tue, Jan 13, 2026 at 12:01:13PM -0600, Sreedevi Joshi wrote:
> When deleting a flow rule using "ethtool -N <dev> delete <location>",
> idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even
> though ethtool doesn't populate this field for delete operations. The
> uninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or
> RX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate
> rule deletions. Remove the unnecessary sideband action enable check and
> ring_cookie validation during delete operations since action validation
> is not required when removing existing rules.
> 
> Fixes: ada3e24b84a0 ("idpf: add flow steering support")
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

Thanks,

I agree with your analysis.
And that the problem was introduced by the cited commit.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix flow rule delete failure due to invalid validation

[Paul Menzel]

[Cc: +Ahmed Zaki]

Dear Sreedevi,


Thank you for your patch.

Am 13.01.26 um 19:01 schrieb Sreedevi Joshi:
> When deleting a flow rule using "ethtool -N <dev> delete <location>",
> idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even
> though ethtool doesn't populate this field for delete operations. The
> uninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or
> RX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate
> rule deletions. Remove the unnecessary sideband action enable check and
> ring_cookie validation during delete operations since action validation
> is not required when removing existing rules.
> 
> Fixes: ada3e24b84a0 ("idpf: add flow steering support")
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> ---
>   drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> index 2efa3c08aba5..49cefb973f4d 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
> @@ -307,9 +307,6 @@ static int idpf_del_flow_steer(struct net_device *netdev,
>   	vport_config = vport->adapter->vport_config[np->vport_idx];
>   	user_config = &vport_config->user_config;
>   
> -	if (!idpf_sideband_action_ena(vport, fsp))
> -		return -EOPNOTSUPP;
> -
>   	rule = kzalloc(struct_size(rule, rule_info, 1), GFP_KERNEL);
>   	if (!rule)
>   		return -ENOMEM;

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix flow rule delete failure due to invalid validation

[Paul Menzel]

[Cc: Remove Ahmed as address bounces]

Am 16.01.26 um 18:39 schrieb Paul Menzel:

> Dear Sreedevi,
> 
> 
> Thank you for your patch.
> 
> Am 13.01.26 um 19:01 schrieb Sreedevi Joshi:
>> When deleting a flow rule using "ethtool -N <dev> delete <location>",
>> idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even
>> though ethtool doesn't populate this field for delete operations. The
>> uninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or
>> RX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate
>> rule deletions. Remove the unnecessary sideband action enable check and
>> ring_cookie validation during delete operations since action validation
>> is not required when removing existing rules.
>>
>> Fixes: ada3e24b84a0 ("idpf: add flow steering support")
>> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
>> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>> ---
>>   drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/ 
>> net/ethernet/intel/idpf/idpf_ethtool.c
>> index 2efa3c08aba5..49cefb973f4d 100644
>> --- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
>> +++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
>> @@ -307,9 +307,6 @@ static int idpf_del_flow_steer(struct net_device 
>> *netdev,
>>       vport_config = vport->adapter->vport_config[np->vport_idx];
>>       user_config = &vport_config->user_config;
>> -    if (!idpf_sideband_action_ena(vport, fsp))
>> -        return -EOPNOTSUPP;
>> -
>>       rule = kzalloc(struct_size(rule, rule_info, 1), GFP_KERNEL);
>>       if (!rule)
>>           return -ENOMEM;
> 
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul