From: Inochi Amaoto <inochiama@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Inochi Amaoto <inochiama@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Karol Gugala <kgugala@antmicro.com>,
Mateusz Holenko <mholenko@antmicro.com>,
Gabriel Somlo <gsomlo@gmail.com>, Joel Stanley <joel@jms.id.au>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH net-next] net: ethernet: litex: use devm_register_netdev() to register netdev
Date: Sat, 17 Jan 2026 08:30:18 +0800 [thread overview]
Message-ID: <aWrX3KKsOke4Z-3c@inochi.infowork> (raw)
In-Reply-To: <3e326797-b4c1-424f-8cf1-f0095e33e0bc@lunn.ch>
On Fri, Jan 16, 2026 at 06:20:05PM +0100, Andrew Lunn wrote:
> On Fri, Jan 16, 2026 at 08:31:50AM +0800, Inochi Amaoto wrote:
> > Use devm_register_netdev to avoid unnecessary remove() callback in
> > platform_driver structure.
>
> > - netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv));
> > + netdev = devm_alloc_etherdev(dev, sizeof(*priv));
> > if (!netdev)
> > return -ENOMEM;
>
> The commit message does not fit the actual change.
>
> You probably want to split this into multiple patches. Ideally you
> want lots of small patches with good commit messages which are
> obviously correct.
>
In fact, I just change them by the way and it is not a obvious change,
OK, I will split it and send a new version.
Regards,
Inochi
prev parent reply other threads:[~2026-01-17 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 0:31 [PATCH net-next] net: ethernet: litex: use devm_register_netdev() to register netdev Inochi Amaoto
2026-01-16 17:20 ` Andrew Lunn
2026-01-17 0:30 ` Inochi Amaoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWrX3KKsOke4Z-3c@inochi.infowork \
--to=inochiama@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=gsomlo@gmail.com \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=looong.bin@gmail.com \
--cc=mholenko@antmicro.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox