From: Cong Wang <xiyou.wangcong@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>, netdev@vger.kernel.org
Subject: Re: [Patch net v8 0/9] netem: Fix skb duplication logic and prevent infinite loops
Date: Fri, 30 Jan 2026 12:53:42 -0800 [thread overview]
Message-ID: <aX0aVgCBTGpGYaJV@pop-os.localdomain> (raw)
In-Reply-To: <20260127091556.052604cd@kernel.org>
On Tue, Jan 27, 2026 at 09:15:56AM -0800, Jakub Kicinski wrote:
> On Sun, 18 Jan 2026 10:07:37 -0500 Jamal Hadi Salim wrote:
> > On Sun, Jan 18, 2026 at 1:16 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> > > This patchset fixes the infinite loops due to duplication in netem, the
> > > real root cause of this problem is enqueuing to the root qdisc, which is
> > > now changed to enqueuing to the same qdisc. This is more reasonable,
> > > more intuitive from users' perspective, less error-prone and more elegant
> > > from kernel developers' perspective.
> > >
> > > Please see more details in patch 4/9 which contains two pages of detailed
> > > explanation including why it is safe and better.
> > >
> > > This reverts the offending commits from William which clearly broke
> > > mq+netem use cases, as reported by two users.
> > >
> > > All the TC test cases pass with this patchset.
> > >
> >
> > These patches should not be considered for any review because they are
> > not following the rules that are set for the community. The rules,
> > which are well documented, state that you must cc all stakeholders.
> > When someone does this _on purpose_ such as Cong, some accountability
> > needs to be imposed. I would say totally ignoring these patches is one
> > option. Otherwise anyone can just throw a tantrum and decide those
> > rules dont apply to them. Either that or we modify the rules to state
> > it is ok to do this..
>
> We (the netdev maintainers) had a chat off list and concluded that it'd
> be great if we (the two of you and one maintainer) met over VC. Either
> technical solution is fine, but we want to make sure there's no ongoing
> animosity. No agenda for the meeting, just want to make sure you can
> have a friendly chat. We can talk about the weather, AI code reviews or
> everyone's favorite animals. At the end of the meeting we can either
> decide or flip a coin.
I offered people involved here for a video chat, *check note*, in
26 Nov 2025:
https://lore.kernel.org/netdev/aSe%2FIfNSZBTTAfTA@pop-os.localdomain/
8 Jul 2025:
https://lore.kernel.org/netdev/aG2OUoDD2m5MqdSz@pop-os.localdomain/
No one responded, obviously.
Jakub, please let me know how to talk to people who kept rejecting to
talk. It is just logically impossible to me, and I have tried my best.
I wish you best luck for doing so.
Thanks!
next prev parent reply other threads:[~2026-01-30 20:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 6:15 [Patch net v8 0/9] netem: Fix skb duplication logic and prevent infinite loops Cong Wang
2026-01-18 6:15 ` [Patch net v8 1/9] net_sched: Check the return value of qfq_choose_next_agg() Cong Wang
2026-01-18 6:15 ` [Patch net v8 2/9] Revert "net/sched: Restrict conditions for adding duplicating netems to qdisc tree" Cong Wang
2026-01-18 6:15 ` [Patch net v8 3/9] Revert "selftests/tc-testing: Add tests for restrictions on netem duplication" Cong Wang
2026-01-18 6:15 ` [Patch net v8 4/9] net_sched: Implement the right netem duplication behavior Cong Wang
2026-01-18 6:15 ` [Patch net v8 5/9] selftests/tc-testing: Add a nested netem duplicate test Cong Wang
2026-01-18 6:15 ` [Patch net v8 6/9] selftests/tc-testing: Add a test case for prio with netem duplicate Cong Wang
2026-01-18 6:15 ` [Patch net v8 7/9] selftests/tc-testing: Add a test case for mq " Cong Wang
2026-01-18 6:15 ` [Patch net v8 8/9] selftests/tc-testing: Update test cases " Cong Wang
2026-01-18 6:15 ` [Patch net v8 9/9] selftests/tc-testing: Add a test case for HTB with netem Cong Wang
2026-01-18 15:07 ` [Patch net v8 0/9] netem: Fix skb duplication logic and prevent infinite loops Jamal Hadi Salim
2026-01-21 17:08 ` Simon Horman
2026-01-21 18:50 ` Jamal Hadi Salim
2026-01-27 17:15 ` Jakub Kicinski
2026-01-30 20:53 ` Cong Wang [this message]
2026-01-30 21:18 ` Jakub Kicinski
2026-01-30 21:32 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aX0aVgCBTGpGYaJV@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox