From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E11C30F7FE for ; Wed, 21 Jan 2026 01:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768959493; cv=none; b=LHV+60hGK35HW1dLoCRa/2A/bj+K4DzaUOYWyGph/v51bj/3NRhthPeetEtv7mUUCb1WyUpA3r1WA8sQBpB9vCi10SFBYIeYzfiBqm6ZyGgmD7Rlp75liGnbTsN04/HWIl/56rlo+Gp4MudeND58c4wIbGDnfomIPFizvSz90Qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768959493; c=relaxed/simple; bh=vWu9HLOleefdsDITsXsJ53ZaMRnGMvdVMKyNUSlnqlM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tz9zLpwwWJDoKsWgCOSt7MeRPRtYnujYLhBeE2zlBycE3RSl6d5aN+gaWD4xNnvCZdty2nTORCOfl5d63dHQCNlF22kkZIiRUDkYnDbBWBfrdcicAeA9idL4jyJEO7QYtUAsC0D1hvtQ3JXzXO/ABILwgCwleX13DT0Y0uSdg3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eFY49dGp; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eFY49dGp" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-12460a7caa2so3880662c88.1 for ; Tue, 20 Jan 2026 17:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768959484; x=1769564284; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A5yAAJyzuotg25Ij3sl9iHvHzE6qHnmlHIRrb6J8qac=; b=eFY49dGpmOYOoazjJHNCGSdpJhNCMkgt5fpUQoGjUD+mwogtrClFPhvXc7L58zB+Cv 6/UqzPNKW4dtTTT7iOZdlIuxGtMouUMMEjk9LXbLw2zNcVwseakFH7bk4fGv8/4LfMjJ 3bT6PqJUwMMCgmNonZkvMnnz11iB2NrB/oBJuoQZC2aHYPdiCPd371yQOlEWCY5IN9FV eQxzSmzrPGCplR4ZL5PvcaHxeq3/GShBsS5C+LnJeQGTvI9nbo39FAabzXsDy/vgevud h5haKtjOTlVg0Iz2l0ZTSdUkJBbBjeq0DOjU+XnLhl1FIul5Sv32Evxj870MN/7i7trT JeTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768959484; x=1769564284; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A5yAAJyzuotg25Ij3sl9iHvHzE6qHnmlHIRrb6J8qac=; b=UVhglxDsezYf/27GnafLBbz0/Jl9FT0TPgKDjAxIclzUsTrIR8+IpgT3ES/L7aTWf4 Ia6DZmoFFGlrd7H0RE0PfwB7DzLn28DYXQj9CtMRcrCX70f6w0z4nlDWyleFdywLpMVA KpvOt+ZVgY80i/f+sx5MZT6yuJN4y6c8+lmnXymSfW+/HawWxLYsWtTArDOKZ+1473kC /8HsdbX4j4FC+n7zRo5LerQY1xIru/iR/odkm5iL7ukjJr+ph9pBn0aL9ORHyQmypeZS Qm119mqiA72FYgzliHnmw7dUzJwGdyTuHbo3d3/TMBXkcSQi6qYgrBJ0WgUnPGzAXLZA jWAQ== X-Forwarded-Encrypted: i=1; AJvYcCWZNKCuCEW8VOQEaIFuGU1PW3cLk9yowLH1yLJAhVX8PPgQyIJ9OMupYlYyW7VJdN5B0+5sqs8=@vger.kernel.org X-Gm-Message-State: AOJu0YwBxFCuzxSo9oxxxtJzt3iMkxNpPHdvJ5+uz1hSmkHq0eEydf7m 9pW3M3JFgk0mD44lfhd99CDTjugLi2sReYm6XasCOT3pn/7HUVNhUthR X-Gm-Gg: AZuq6aJCTAhtkrhOHv7QixovVMtwwc0f2h8A42G347qh9xvnXzat+oUnzDUw9vfLNZJ gPGxzCasJzu5I3BYs3J7hUlVi3ECUMukzW1IZkieYK8rASgI7NO6bS8W0uxPO/115MMHEOWbIh+ GmLFvHsVnQ8yIVILl3LvOgbTk2EnywB2f3/tMRe/+ZdNV5hTEnairal8Ymk00Cjnovd5CyvbCyw Ps5mBBhoaSCyUkGnqoNibXiBoUfW69SOcjK929XWRTMUZbXZlJT2XyMAlVDw4M/gKYXANJ63Gu+ kPaVDjbbPWX5YHSThrrCAGhyaaQBYoZDAFYMJw5ZogYiQ9Z9X9CCfNoXU0wv/o/n6kotLwtGy7C FsulVS/tXSahMNSjI3MxVFx8SMqB3xwjF6TNTwOnf8x+2RrWhaeiwaAytPOm4viEuLoxiX5D0uL e/GogwMsvtYA== X-Received: by 2002:a05:7301:2b84:b0:2b7:f12:9503 with SMTP id 5a478bee46e88-2b70f1295ccmr1043461eec.30.1768959484158; Tue, 20 Jan 2026 17:38:04 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7047b099bsm3361798eec.31.2026.01.20.17.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 17:38:03 -0800 (PST) Date: Wed, 21 Jan 2026 09:37:53 +0800 From: Inochi Amaoto To: Andrew Lunn , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Russell King (Oracle)" , Yanteng Si , Yao Zi , Vladimir Oltean , Lad Prabhakar , Choong Yong Liang , Maxime Chevallier , Chen-Yu Tsai , Shangjuan Wei , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260120043609.910302-1-inochiama@gmail.com> <20260120043609.910302-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 21, 2026 at 02:29:23AM +0100, Andrew Lunn wrote: > On Wed, Jan 21, 2026 at 06:36:01AM +0800, Inochi Amaoto wrote: > > On Tue, Jan 20, 2026 at 02:56:26PM +0100, Andrew Lunn wrote: > > > > +/* Note: the delay step value is at 0.1ps */ > > > > +static const unsigned int k3_delay_step_10x[4] = { > > > > + 367, 493, 559, 685 > > > > +}; > > > > > > Am i reading it correctly that RGMII delays are limited to these four > > > values? > > > > > > If so, please add this list to the DT binding. > > > > > > > No, these value are just adjustment interval, and it is also > > controlled by another code register, the final delay is calculated > > by the following formula: > > > > delay = delay_step * delay_code * 0.9; > > > > So the delay configuration needs to be calculated instead of > > directly assigned. > > O.K. > > So what is the actual range? Can is do 1000ps? 2000ps? 3000ps? Should > there be a basic range check to avoid dumb typos? It can have a pretty big ranges, and I was told the total delay is fine to work between [1200, 2800]. I guess it is fine for us to check the upper limit? Regards, Inochi