From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEEA7337BA6; Wed, 21 Jan 2026 16:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769014777; cv=none; b=CMGiF3drPfUkEJLoGrB45AMzWVWBj+gvfTOpumIjZZCNnR33zh6t5F41ttxqpOBTPKv8afcOamBB7jYoc2YVMuySVUgCYqeR5EbxmMx9tGM1KH/kolVCrSL5kMijvnk7ynHBLhwpfpJXxoXXuLnhVwrcSyLgP/VvBp+tmEYZShc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769014777; c=relaxed/simple; bh=ruJcwsyHlH9v6pfiG+6Y7INjT5x/5/341UtTiiGk9QY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HScQJl3/W8ttBB0hl8hEMW4DjASBCtoZbGU13J5g1pBOpmGcbN23ohDX+1UXaxNL3tHOhy+KxiXs1fcQfxV6ptrEW3QzEEtuzc3iZZnJI3IJhJxP8fdVaZZ8Cj9oEN8jcAfmyhvivQebMvODPmAJFdBO6ZPHuRbsBLqg3YVUvhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dkczaqt9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dkczaqt9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A076FC4CEF1; Wed, 21 Jan 2026 16:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769014776; bh=ruJcwsyHlH9v6pfiG+6Y7INjT5x/5/341UtTiiGk9QY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dkczaqt9URThweOArTTVF9tgMo8wL7yk4qz8J8GHzRixXbqTpRMpQ8sMCRN6JGphh 6Hu2/qQUC9kgvRzs/JwFfxkabaqUSx17/HVb5P/NYsrbDKqPpEpvKY37oxRn9qECZO vA7XWcIUdjrg50dpDWeuODPXyvNKkeX60rvaPhLmvkbD0TZq2KtvYm1VMIR0peV+Dl KicHYz9GrEFZOYquGPSBMtAWPGCFQKRUVlKAC5KWmP6zx9FN0HDgfhXYyXEag6MH6n xTD753x3paV9ANUYP1AQrGrTkT8x2s2JkBypZ2s6QpVbfARVIqaVq7f03efFBC6jAV slq+aHnkjVQZQ== Date: Wed, 21 Jan 2026 16:59:29 +0000 From: Simon Horman To: Daniel Golle Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Wunderlich , Chad Monroe , Cezary Wilmanski , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: Re: [PATCH v7 net-next 4/4] net: dsa: add basic initial driver for MxL862xx switches Message-ID: References: <15b0adf5074c601e033fd2338fb27fb666b5d16b.1768707226.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15b0adf5074c601e033fd2338fb27fb666b5d16b.1768707226.git.daniel@makrotopia.org> On Sun, Jan 18, 2026 at 03:46:07AM +0000, Daniel Golle wrote: ... > +static int mxl862xx_isolate_port(struct dsa_switch *ds, int port) > +{ > + struct mxl862xx_bridge_port_config br_port_cfg = {}; > + struct mxl862xx_bridge_alloc br_alloc = {}; > + int ret; > + > + ret = MXL862XX_API_READ(ds->priv, MXL862XX_BRIDGE_ALLOC, br_alloc); > + if (ret) { > + dev_err(ds->dev, "failed to allocate a bridge for port %d\n", port); > + return ret; > + } > + > + br_port_cfg.bridge_id = br_alloc.bridge_id; > + br_port_cfg.bridge_port_id = DSA_MXL_PORT(port); > + br_port_cfg.mask = MXL862XX_BRIDGE_PORT_CONFIG_MASK_BRIDGE_ID | > + MXL862XX_BRIDGE_PORT_CONFIG_MASK_BRIDGE_PORT_MAP | > + MXL862XX_BRIDGE_PORT_CONFIG_MASK_MC_SRC_MAC_LEARNING | > + MXL862XX_BRIDGE_PORT_CONFIG_MASK_VLAN_BASED_MAC_LEARNING; > + br_port_cfg.src_mac_learning_disable = true; > + br_port_cfg.vlan_src_mac_vid_enable = false; > + br_port_cfg.vlan_dst_mac_vid_enable = false; > + br_port_cfg.bridge_port_map[0] = DSA_MXL_CPU_PORTS(ds); Hi Daniel, .bridge_port_id, .mask, and elements of .bridge_port_map[] are little-endian integers. But are being assigned host byte-order values here and elsewhere. Flagged by Sparse [1]. [1] This particular commit, from Al Viro's tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/sparse.git/commit/?id=2634e39bf02697a18fece057208150362c985992 To address this mess: https://lore.kernel.org/all/bf5b9a62-a120-421e-908d-1404c42e0b60@kernel.org/ > + > + return MXL862XX_API_WRITE(ds->priv, MXL862XX_BRIDGEPORT_CONFIGSET, br_port_cfg); > +} ... -- pw-bot: cr