public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Boris Pismenny <borisp@mellanox.com>,
	"David S. Miller" <davem@davemloft.net>,
	Florian Westphal <fw@strlen.de>,
	Kristian Evensen <kristian.evensen@gmail.com>,
	Leon Romanovsky <leon@kernel.org>,
	Leon Romanovsky <leonro@nvidia.com>,
	Raed Salem <raeds@mellanox.com>, Raed Salem <raeds@nvidia.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Yossi Kuperman <yossiku@mellanox.com>,
	Network Development <netdev@vger.kernel.org>,
	linux-security-module <linux-security-module@vger.kernel.org>,
	Aviad Yehezkel <aviadye@nvidia.com>
Subject: Re: [PATCH] xfrm: force flush upon NETDEV_UNREGISTER event
Date: Thu, 22 Jan 2026 12:32:16 +0100	[thread overview]
Message-ID: <aXIKwNJv59KnsnLw@secunet.com> (raw)
In-Reply-To: <447378de-3cc9-44f5-872e-a1fc477f591e@I-love.SAKURA.ne.jp>

On Thu, Jan 22, 2026 at 08:28:31PM +0900, Tetsuo Handa wrote:
> On 2026/01/22 20:15, Steffen Klassert wrote:
> > Hm, I'd say we should not try to offload to a device that does
> > not support NETIF_F_HW_ESP.
> 
> I was about to post the patch below, but you are suggesting that "do not allow calling
> xfrm_dev_state_add()/xfrm_dev_policy_add() if (dev->features & NETIF_F_HW_ESP) == 0" ?

As said, I think this is the correct way to do it. But let's wait
on opinions from the hardware people.

  reply	other threads:[~2026-01-22 11:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-17 16:03 xfrm: question regarding NETDEV_UNREGISTER handling Tetsuo Handa
2026-01-19 11:19 ` [PATCH] xfrm: force flush upon NETDEV_UNREGISTER event Tetsuo Handa
2026-01-22  8:24   ` Tetsuo Handa
2026-01-22 11:15     ` Steffen Klassert
2026-01-22 11:28       ` Tetsuo Handa
2026-01-22 11:32         ` Steffen Klassert [this message]
2026-01-22 13:07           ` Tetsuo Handa
2026-01-26 11:07             ` Leon Romanovsky
2026-01-26 15:57               ` Tetsuo Handa
2026-01-26 14:16             ` Sabrina Dubroca
2026-01-26 22:41       ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXIKwNJv59KnsnLw@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=aviadye@nvidia.com \
    --cc=borisp@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=kristian.evensen@gmail.com \
    --cc=leon@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=raeds@mellanox.com \
    --cc=raeds@nvidia.com \
    --cc=saeedm@mellanox.com \
    --cc=yossiku@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox