From: Simon Horman <horms@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Breno Leitao <leitao@debian.org>,
Andy Roulin <aroulin@nvidia.com>,
Francesco Ruggeri <fruggeri@arista.com>,
Stephen Hemminger <stephen@networkplumber.org>,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next v2 0/8] net: neighbour: Notify changes atomically
Date: Fri, 23 Jan 2026 15:28:15 +0000 [thread overview]
Message-ID: <aXOTj4gp9ONKVnwa@horms.kernel.org> (raw)
In-Reply-To: <cover.1769012464.git.petrm@nvidia.com>
On Wed, Jan 21, 2026 at 05:43:34PM +0100, Petr Machata wrote:
...
> v2:
> - Patch #2:
> - Drop the __acquires / __releases annotations at neigh_notify().
> They are not necessary with a symmetrically locking function.
> - Retain the R-b tag for this change.
> - Patch #8:
> - Do not skip the notification from inside the
> atomic_read(&neigh->probes) >= neigh_max_probes(neigh)
> conditional. Instead set a flag, and goto out after the
> notification if the flag is set.
> - Move the __neigh_notify() call another block up above the
> NUD_IN_TIMER check. That belongs logically together with
> the (NUD_INCOMPLETE | NUD_PROBE) check afterwards, no sense
> to split the two conditionals with the notifier.
I'm ambivalent on the last point. And at any rate, I don't think my next
point warrants a re-spin. But I do wonder if the same applies to
neigh_update_process_arp_queue and neigh_fill_info.
That notwithstanding, this series looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-01-23 15:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 16:43 [PATCH net-next v2 0/8] net: neighbour: Notify changes atomically Petr Machata
2026-01-21 16:43 ` [PATCH net-next v2 1/8] net: core: neighbour: Add a neigh_fill_info() helper for when lock not held Petr Machata
2026-01-21 16:43 ` [PATCH net-next v2 2/8] net: core: neighbour: Call __neigh_notify() under a lock Petr Machata
2026-01-21 16:43 ` [PATCH net-next v2 3/8] net: core: neighbour: Extract ARP queue processing to a helper function Petr Machata
2026-01-21 16:43 ` [PATCH net-next v2 4/8] net: core: neighbour: Process ARP queue later Petr Machata
2026-01-21 16:43 ` [PATCH net-next v2 5/8] net: core: neighbour: Inline neigh_update_notify() calls Petr Machata
2026-01-21 16:43 ` [PATCH net-next v2 6/8] net: core: neighbour: Reorder netlink & internal notification Petr Machata
2026-01-25 22:59 ` Jakub Kicinski
2026-01-21 16:43 ` [PATCH net-next v2 7/8] net: core: neighbour: Make one netlink notification atomically Petr Machata
2026-01-21 16:43 ` [PATCH net-next v2 8/8] net: core: neighbour: Make another " Petr Machata
2026-01-23 15:28 ` Simon Horman [this message]
2026-01-25 23:00 ` [PATCH net-next v2 0/8] net: neighbour: Notify changes atomically patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXOTj4gp9ONKVnwa@horms.kernel.org \
--to=horms@kernel.org \
--cc=aroulin@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fruggeri@arista.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leitao@debian.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox