From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 2/4] gro: change the BUG_ON() in gro_pull_from_frag0()
Date: Fri, 23 Jan 2026 16:45:40 +0000 [thread overview]
Message-ID: <aXOltKyRoWvUTfKf@horms.kernel.org> (raw)
In-Reply-To: <20260122045720.1221017-3-edumazet@google.com>
On Thu, Jan 22, 2026 at 04:57:17AM +0000, Eric Dumazet wrote:
> Replace the BUG_ON() which never fired with a DEBUG_NET_WARN_ON_ONCE()
>
> $ scripts/bloat-o-meter -t vmlinux.1 vmlinux.2
> add/remove: 2/2 grow/shrink: 1/1 up/down: 370/-254 (116)
> Function old new delta
> gro_try_pull_from_frag0 - 196 +196
> napi_gro_frags 771 929 +158
> __pfx_gro_try_pull_from_frag0 - 16 +16
> __pfx_gro_pull_from_frag0 16 - -16
> dev_gro_receive 1514 1464 -50
> gro_pull_from_frag0 188 - -188
> Total: Before=22565899, After=22566015, chg +0.00%
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Hi Eric,
Am I right in thinking that the motivation is to reduce this
check to zero-code in the case of !CONFIG_DEBUG_NET?
next prev parent reply other threads:[~2026-01-23 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 4:57 [PATCH net-next 0/4] net: few critical helpers are inlined again Eric Dumazet
2026-01-22 4:57 ` [PATCH net-next 1/4] net: always inline skb_frag_unref() and __skb_frag_unref() Eric Dumazet
2026-01-22 4:57 ` [PATCH net-next 2/4] gro: change the BUG_ON() in gro_pull_from_frag0() Eric Dumazet
2026-01-23 16:45 ` Simon Horman [this message]
2026-01-22 4:57 ` [PATCH net-next 3/4] net: inline net_is_devmem_iov() Eric Dumazet
2026-01-22 4:57 ` [PATCH net-next 4/4] net: inline get_netmem() and put_netmem() Eric Dumazet
2026-01-26 20:26 ` Bobby Eshleman
2026-01-25 22:00 ` [PATCH net-next 0/4] net: few critical helpers are inlined again patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXOltKyRoWvUTfKf@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox