From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE803EBF06 for ; Fri, 23 Jan 2026 20:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769199288; cv=none; b=R6uRPlaHmFrMt0d21NgrUJxYdNlcgeWR6UCIvMogICgKkvuxlly1kk6IBYpUTiVQRnU9dnONP1uJtZzmYimkINsxejIi1bEhJjSyZLZYdCpKks7PHnNe99bur1dLrt+KP8vWG6jGRVC27NTgDoMAbnRovv5D2e8jH6X2Mq24AEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769199288; c=relaxed/simple; bh=GnDzDaAq8IjaJTTGRRh0Qx+PjtEQDotnGHUbuy+Aw5s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pGE4tyGHLEZwNWlqT83SWsPEVULDr2KIRB2drte+HeDEWsJxHBwfIYlKlOTauT4LAt9aYKP3W4OU9XI0kLp7az3iHt/GoFZOxwbR8+pVpESsElTslxEkz4yRRH2pUb6tnIqzmAThSgBnyb00NHVC0U//A69evNn/K8IeeRTeeWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s6ib5QRq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s6ib5QRq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2F2DC4CEF1; Fri, 23 Jan 2026 20:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769199288; bh=GnDzDaAq8IjaJTTGRRh0Qx+PjtEQDotnGHUbuy+Aw5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s6ib5QRqY5q/UZdugTHRwCSAOW/VCpLhdswV7ig1ldBOU5PhcYx+wO+KAFlyqlTH/ 0mrmoNCeaWzkwZ59KqotP5dqvMEE4PY6hUZGy/QHJfFnVCBBJfMJjOdtQAE2qxHC6B HeZC3inlwS2iWvP+6oqrpEBfnNTLEXEhshSgC4Sz+/9C52FOZNNXhLqDQa8oMY+VxY 9DHC+rYR0WsiGSO4IgXmxtljx3jaFSHQgxYWY7KvhH+QkpSsYDYzFna3Fk5EVxASY+ EQKIdmqH5pXVWfjVpsO1cpK3N0S8PKcS2Xybl02Es0Eq8DHplC1GxEMVAHq9vGHVD6 P1LQ+aYkjEFbA== Date: Fri, 23 Jan 2026 20:14:44 +0000 From: Simon Horman To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, eric.dumazet@gmail.com, Mahesh Bandewar Subject: Re: [PATCH v2 net-next] ipvlan: remove ipvlan_ht_addr_lookup() Message-ID: References: <20260122165049.2366985-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260122165049.2366985-1-edumazet@google.com> On Thu, Jan 22, 2026 at 04:50:49PM +0000, Eric Dumazet wrote: > ipvlan_ht_addr_lookup() is called four times and not inlined. > > Split it to ipvlan_ht_addr_lookup6() and ipvlan_ht_addr_lookup4() > and rework ipvlan_addr_lookup() to call these helpers once, > so that they are (auto)inlined. > > After this change, ipvlan_addr_lookup() is faster, and we save > 350 bytes of text on x86_64. > > $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new > add/remove: 0/2 grow/shrink: 1/0 up/down: 123/-473 (-350) > Function old new delta > ipvlan_addr_lookup 467 590 +123 > __pfx_ipvlan_ht_addr_lookup 16 - -16 > ipvlan_ht_addr_lookup 457 - -457 > Total: Before=22571833, After=22571483, chg -0.00% > > Signed-off-by: Eric Dumazet > Cc: Mahesh Bandewar > --- > v2: guard ipvlan_ht_addr_lookup6() with CONFIG_IPV6 (kernel test robot) > v1: https://lore.kernel.org/netdev/20260121215728.560645-1-edumazet@google.com/ > drivers/net/ipvlan/ipvlan_core.c | 55 ++++++++++++++++++++------------ > 1 file changed, 34 insertions(+), 21 deletions(-) Reviewed-by: Simon Horman