public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Mohsin Bashir <mohsin.bashr@gmail.com>,
	netdev@vger.kernel.org, alexanderduyck@fb.com,
	alok.a.tiwari@oracle.com, andrew+netdev@lunn.ch, andrew@lunn.ch,
	chuck.lever@oracle.com, davem@davemloft.net,
	donald.hunter@gmail.com, edumazet@google.com, gal@nvidia.com,
	horms@kernel.org, idosch@nvidia.com, jacob.e.keller@intel.com,
	kernel-team@meta.com, kory.maincent@bootlin.com, lee@trager.us,
	pabeni@redhat.com, vadim.fedorenko@linux.dev,
	kernel@pengutronix.de
Subject: Re: [PATCH net-next 0/3] net: ethtool: Track TX pause storm
Date: Fri, 23 Jan 2026 22:04:39 +0100	[thread overview]
Message-ID: <aXPiZ8H-usRn1pcD@pengutronix.de> (raw)
In-Reply-To: <20260123104031.16d914e4@kernel.org>

On Fri, Jan 23, 2026 at 10:40:31AM -0800, Jakub Kicinski wrote:
> On Fri, 23 Jan 2026 12:28:13 +0100 Oleksij Rempel wrote:
> > Here is a TL;DR summary of my questions regarding the pause storm logic
> > :)
> 
> Eh, did you get AI to help write the full version? :) So much text :)

Yes, to reduce the text! Sorry, sometimes I have word diarrhea :D

> > - Should we standardize an "RX Watchdog" mechanism in the core instead of
> >   or in addition to driver-specific stats?
> 
> Our primary use case is machine is hard-wedged. Either Linux crash, or
> kexec died, or UEFI issue. So it must be the device that implements the
> logic.
> 
> Florian was proposing a hook to auto-disable pause from the crash
> notifier. It sounds like your use case is closer to that?

It is valid use case - it will be nice to have it too.

In my tests, I was able to trigger an Rx stall and a pause storm (if
flow control is enabled), for example by partially disrupting the USB
connection. Since this controller is used in medical devices, it will
be good to detect these anomalies and attempt recovery.

Sorry, here I want to hijack this discussion for my purpose :)

Since a pause storm is only a symptom of an Rx stall, should we have a
common method to detect it? Is it even reasonably possible? In my cases,
I tried to detect it by monitoring the level of the Rx queue, Rx HW
counters, and Rx SW counters. But maybe I just have a blind spot and
this is a naive way to detect things.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2026-01-23 21:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 19:21 [PATCH net-next 0/3] net: ethtool: Track TX pause storm Mohsin Bashir
2026-01-22 19:21 ` [PATCH net-next 1/3] net: ethtool: Track pause storm events Mohsin Bashir
2026-01-23 21:27   ` Oleksij Rempel
2026-01-23 22:15     ` Jakub Kicinski
2026-01-24  9:28       ` Oleksij Rempel
2026-01-22 19:21 ` [PATCH net-next 2/3] eth: fbnic: Add protection against pause storm Mohsin Bashir
2026-01-22 19:21 ` [PATCH net-next 3/3] eth: fbnic: Fetch TX pause storm stats Mohsin Bashir
2026-01-23  9:34 ` [PATCH net-next 0/3] net: ethtool: Track TX pause storm Oleksij Rempel
2026-01-23 11:28   ` Oleksij Rempel
2026-01-23 18:40     ` Jakub Kicinski
2026-01-23 19:31       ` Mohsin Bashir
2026-01-23 21:04       ` Oleksij Rempel [this message]
2026-01-23 22:21         ` Jakub Kicinski
2026-01-25  9:59       ` Gal Pressman
2026-01-25 22:30         ` Jakub Kicinski
2026-01-26  6:51           ` Gal Pressman
2026-01-23 19:36 ` Florian Fainelli
2026-01-23 20:05   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXPiZ8H-usRn1pcD@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=alexanderduyck@fb.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=chuck.lever@oracle.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=jacob.e.keller@intel.com \
    --cc=kernel-team@meta.com \
    --cc=kernel@pengutronix.de \
    --cc=kory.maincent@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=lee@trager.us \
    --cc=mohsin.bashr@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox