From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3573335BA; Sat, 24 Jan 2026 00:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769213813; cv=none; b=SfnhmKNE5XOXC3qA9kWXieAmfnxoqISmKYvPLIbH2H0R7J8EtytJgwrbpkkouhE7vPuvVC8IgnaXB8dKPFjq2DixjXsnRbMB1AyhPrKNRUGMHgAtSSIfxi1H2sMMYDUK8CTImDMZYJcMBgwLmWesbqhT3redWq3CChTsah4QgUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769213813; c=relaxed/simple; bh=h3CIg4bLQDlSIE2Ih2cdfQUqE+t4LWsNlQ4sUBWaaRk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H4M3OvH+gasaChRdN0Kb4rFLyBmfCTWOZ5OuBVAGSghLOqyfB9k76XAXtYCc+4+EflCzYL0gT6mvMOqbmxEEqSA9sdxuIUUR9UO2ZYlrFRei0s5tua/XcUXXjtEkhlsl8Iyv/4vp9fSMEfEJlBB7ZTox0ihrlYafnnHJ2b5rcM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=vRSuX8oU; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="vRSuX8oU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iZB71uqjML4w9rR8etBjxBLKoRFzZrwDxpZiOxS2Ois=; b=vRSuX8oU8/P4wCgCBM9K3rqdta ZFSOeo9EMGRE8fRWUz+5xUaBJKm20kbE8f092osZzm89zIJIQMOMjSriMMCx+XzmPJuvFYIdJShSj C6RH1gHbjhksFQ7BeCFZS5qInVkMFvhmwAXsQYeSqxE6Xfw47SLPKSSm+sJZ1GOhDDbMQtnNxDXb8 y/Ce8GNmcD+0y9WBB7GJhtLZ+wXCCKYyAABUYjOQ5L94CV5sVvOuiKsLow80eINl7lIQntrIo3zVZ 7wAHOswmVW9EA6HQCubITsqcIvNYR0Zkw7w1IXGFjQPET7Lx6RkeLP39OW85A2itOp5AKlNrfwpdT Qo3GrNvg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33206) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vjRKT-000000002e4-0vPd; Sat, 24 Jan 2026 00:16:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vjRKP-000000002Xd-1kQd; Sat, 24 Jan 2026 00:16:37 +0000 Date: Sat, 24 Jan 2026 00:16:37 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH net-next v2 00/14] net: stmmac: SerDes, PCS, BASE-X, and inband goodies Message-ID: References: <20260124000409.36nsxlvkde4zpddk@skbuf> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260124000409.36nsxlvkde4zpddk@skbuf> Sender: Russell King (Oracle) On Sat, Jan 24, 2026 at 02:04:09AM +0200, Vladimir Oltean wrote: > On Fri, Jan 23, 2026 at 11:13:26AM +0000, Russell King (Oracle) wrote: > > According to patchwork, this doesn't apply to net-next. That's odd, > > it was generated on last night's net next, and although there has been > > further work, it rebases cleanly on top of this morning's. How can > > these changes: > > > > drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 6 +++++- > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 20 ++++++++++++++++---- > > 2 files changed, 21 insertions(+), 5 deletions(-) > > > > which happened in net-next overnight result in this change in patch 1: > > > > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > failing to apply? > > > > No, patchwork is clearly wrong. > > Conflicts with commit dc6597fab3e3 ("net: stmmac: dwmac-imx: keep > preamble before sfd on i.MX8MP"), merged in the meantime. > > In include/linux/stmmac.h (your commit "net: stmmac: add stmmac core > serdes support" adds a "struct phy;" line, but that other commit > modifies the context by inserting: > > #define STMMAC_FLAG_KEEP_PREAMBLE_BEFORE_SFD BIT(14) > > (the last stmmac flag in your context, at patch generation time, was: > #define STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY BIT(13) > ) I still maintain that this is silly - to mark all patches as such and without any details about the problem applying the patches is not helpful. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!