Re: [PATCH net-next 1/3] net: ethtool: Track pause storm events

[Oleksij Rempel <o.rempel@pengutronix.de>]

On Fri, Jan 23, 2026 at 02:15:27PM -0800, Jakub Kicinski wrote:
> On Fri, 23 Jan 2026 22:27:19 +0100 Oleksij Rempel wrote:
> > > +      -
> > > +        name: tx-pause-storm-events
> > > +        type: u64
> > > +        doc: >-
> > > +            TX pause storm event count. Increments each time device
> > > +            detects that its pause assertion condition has been true
> > > +            for too long for normal operation. As a result, the device
> > > +            has temporarily disabled its own Pause TX function to
> > > +            protect the network from itself.
> > > +            This counter should never increment under normal overload
> > > +            conditions; it indicates catastrophic failure like an OS
> > > +            crash. The rate of incrementing is implementation specific.  
> > 
> > Hm, we already have the tx pause frame counters. So, the anomaly is
> > visible to the user anyway (even if it isn't explicitly labeled as an
> > anomaly).
> 
> We are trying to prove a negative here, that's why we need a new
> counter. As the doc says this counter should indicate that storm
> is never actually detected under normal conditions. Another thing
> to keep in mind is that we're talking about metric collection at scale,
> so every 1min to 5min.
> 
> > What is not visible to the user is when HW or SW disables flow control.
> > Maybe that is what the counter should represent and be named? Would
> > tx-pause-auto-disabled-events make sense?
> 
> According to our existing uAPI for PFC pause storm is the term of art.

Fair enough. If it is aligned with the existing interface and doing the
same thing, there is no reason to continue this discussion.

For the uAPI part:
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de> 

Thank you,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |