From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CE00263899; Sat, 24 Jan 2026 13:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769260942; cv=none; b=XIJ56WabTXgV0s7uGmcBaHO546hjhDS4ml+GjzcfIIAsLdph6JuCJxhXRZUykga3DW2dzIhZiNdtpCaGnVQXT7M5igTPTckVMmLSVMyNsgNQPDgdskHNZEQ01jibb5+PtKUKmdv4fTJRCAMfrQjebGBlUvVzX+COYjG+qfgBJuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769260942; c=relaxed/simple; bh=ToIaOZgqAD9RJ+1Uhj8Ob1zhp9ZLsHIZHDqohWQufXk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hJLvd/e90L3D3j0RHZf4VUR9ChhO20IyvgxOq+x8r3i7D9SNnnPHPZXag83+BE+wY+aCgKutyBMHcSum71MRQ1icW6R2U/Ce+H5BABzq/aQNIbfmxLnm5aEPZUrACVf6p0ZsSoB6KdryupDdpaWEsFnqsx5cxOhki4QYg1ZxCXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HUywvX5x; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HUywvX5x" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769260940; x=1800796940; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ToIaOZgqAD9RJ+1Uhj8Ob1zhp9ZLsHIZHDqohWQufXk=; b=HUywvX5xDBeV2Gn0J9W2lzp3oTY28Ub5qKGTnoVyyhdSGuSR6B9ql7o4 rt4XG1qvgg4yXvadb9EzlUPzeVgHzu1pFqx35xtkb4aEYF0XeulqAx/PH di35/VtFtgpd3ySPeqheOYREIE/zaDlymDL532pFVTAKq32qtKIGmIfH8 uuntB/c5bj67GYoarlYyfvNlwuV0fkhA+iahBgfn/rOCpx9lU3gpOCOG4 Yi/6S3Hj/1nf+JY2KIiSdoO1odgHe8WV2CMLW6oMdaOgGb5piCF1aNnf4 I89jv5MwI/85r2QGMxwxTNpIKsZw/gA6WPpp/vrGtQt7OdGYhw4RZWhWN w==; X-CSE-ConnectionGUID: NX6pJ8czSrymIt4PrCYlGg== X-CSE-MsgGUID: Ot3lphe5Sea5QGux5nL3dw== X-IronPort-AV: E=McAfee;i="6800,10657,11681"; a="74122886" X-IronPort-AV: E=Sophos;i="6.21,250,1763452800"; d="scan'208";a="74122886" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2026 05:22:19 -0800 X-CSE-ConnectionGUID: PcdYSi6FQLmV/XWr5T9vpw== X-CSE-MsgGUID: sCj+0JBFSj6T+skUwozrVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,250,1763452800"; d="scan'208";a="211723635" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.244.207]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2026 05:22:14 -0800 Date: Sat, 24 Jan 2026 15:22:12 +0200 From: Andy Shevchenko To: Ethan Nelson-Moore Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peter Korsgaard , Petko Manolov , Steve Glendinning , UNGLinuxDriver@microchip.com, Nikita Zhandarovich , Oliver Neukum , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Deepanshu Kartikey , Oleksij Rempel , Max Schulze , Thomas Gleixner , Ingo Molnar , "Gustavo A. R. Silva" , Kees Cook , Eric Biggers Subject: Re: [PATCH v2 net-next] net: usb: remove unnecessary get_drvinfo code and driver versions Message-ID: References: <20260124102042.112101-1-enelsonmoore@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260124102042.112101-1-enelsonmoore@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sat, Jan 24, 2026 at 02:19:45AM -0800, Ethan Nelson-Moore wrote: > Many USB network drivers define get_drvinfo functions which add no > value over usbnet_get_drvinfo, only setting the driver name and > version. usbnet_get_drvinfo automatically sets the driver name, and > separate driver versions are now frowned upon in the kernel. Remove all > driver versions and replace these get_drvinfo functions with references > to usbnet_get_drvinfo where possible. Where that is not possible, > remove unnecessary code to set the driver name. Also remove two > unnecessary initializations from aqc111_get_drvinfo, an inaccurate > comment in pegasus.c, and an unused macro in catc.c. There are three problems with this version: 1) you haven't taken my tag, why? 2) there is no changelog to understand what's going on; 3) the v2 was sent too quickly (usually should be 24h+ between the versions). -- With Best Regards, Andy Shevchenko