From: Simon Horman <horms@kernel.org>
To: Dmitry Skorodumov <dskr99@gmail.com>
Cc: netdev@vger.kernel.org, Dmitry Skorodumov <skorodumov.dmitry@huawei.com>
Subject: Re: [PATCH v2 net-next 0/3] ipvlan: Deduplicate ipv4/ipv6 addr_validator_event code
Date: Mon, 26 Jan 2026 15:06:18 +0000 [thread overview]
Message-ID: <aXeC6hmPiaviXcIx@horms.kernel.org> (raw)
In-Reply-To: <20260123170412.906280-1-skorodumov.dmitry@huawei.com>
On Fri, Jan 23, 2026 at 08:03:53PM +0300, Dmitry Skorodumov wrote:
> This is a bit stylish patches: The code to handle ipv4 and ipv6
> address change are exactly the same. We don't need separate
> functions for them. Just look whether we are called
> with ipvlan_addr4_notifier_block or with ipvlan_addr6_notifier_block
>
> The changed functionality is already covered
> with existing selftests/net/ipvtap_test.sh
Hi Dmitry,
I'm somewhat ambivalent towards the trade-off between
reducing code duplication, and requiring run-time demuxing
between ipv4 and ipv4 code paths and the moderate increase in
code complexity that entails.
But assuming these paths are not performance sensitive I guess
that reducing duplication has the upper hand.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-01-26 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 17:03 [PATCH v2 net-next 0/3] ipvlan: Deduplicate ipv4/ipv6 addr_validator_event code Dmitry Skorodumov
2026-01-23 17:03 ` [PATCH v2 net-next 1/3] ipvlan: const-specifier for functions that use iaddr Dmitry Skorodumov
2026-01-23 17:03 ` [PATCH v2 net-next 2/3] ipvlan: Common code from v6/v4 validator_event Dmitry Skorodumov
2026-01-26 18:01 ` Kuniyuki Iwashima
2026-01-27 5:56 ` Dmitry Skorodumov
2026-01-27 7:37 ` Eric Dumazet
2026-01-27 7:54 ` Dmitry Skorodumov
2026-01-27 8:11 ` Kuniyuki Iwashima
2026-01-23 17:03 ` [PATCH v2 net-next 3/3] ipvlan: common code to handle ipv6/ipv4 address events Dmitry Skorodumov
2026-01-26 15:06 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXeC6hmPiaviXcIx@horms.kernel.org \
--to=horms@kernel.org \
--cc=dskr99@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=skorodumov.dmitry@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox