From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E643C25D1E9; Tue, 27 Jan 2026 07:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769498863; cv=none; b=OzP7XrMyVIooEmBjqkhNn+Xo6PVRqD9ZA1bFLbq6ZqutjTF9luzeZbB5zlRmXp/o8rMFg5CFEjtxc67WucJeVlAgRtHS+ziwtzsfZsEAfairtqnzbtiFkAU03n8w0j1EfE8EEIkDkSN+E/TpSInhN+iXcuxO5Eh9JJBYM86YZrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769498863; c=relaxed/simple; bh=w26CVxumWvLmQH1eL3SSR2Q79MSI1rZOjjpcVGD0jTk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TvQD121jWi6PhjA5zzpn9SqkuLYDd0GgXAS38vkVtJunsTHbRYFNwwKtL42QSC7zgBU3Al5qnNkuXEEs57bRZYVwlsjVmfKGJW0DC09fBFDlTqMOD3Km8sIn05gxwYLWrWnZ/vp3VdxIl1RGEvC6AUqxTZ5AMOobwqZhJbf3Pko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JepuUEF3; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JepuUEF3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769498863; x=1801034863; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=w26CVxumWvLmQH1eL3SSR2Q79MSI1rZOjjpcVGD0jTk=; b=JepuUEF3QzuY80ePwBCnANe9OvKKOmDIGsbaOPtGpnSPuPify22IOh5Q vl1Osc+m4gbWDuZrjQdz4c8ubSrLJSDGznyfcyMKIkwR7sKBIyvetyqmn jo6ShUNx9vVTUjX7XCfmQcIAc7laJPlu8KoYeIn98sdXzPBOXSuTfTmSL Nil+9UW3396cZERFS4ba9kHta+jXcQL5+BvojOGItOixNti15lDLAzuak 5yRiv8E+L1GQw5RLk41qQAATqVtowXgps5Y/uRJkX5w3QPArcSnPrWqjC JLgD04cFwfoJ/i6+Y1xe17j8rd5kVpB/5mDh+9+eouSvswFbaOaCXrShU g==; X-CSE-ConnectionGUID: qXVI0HS/QjuBYG4zFtx2NA== X-CSE-MsgGUID: KEACBC2qRxW1uK1/JPvFMA== X-IronPort-AV: E=McAfee;i="6800,10657,11683"; a="70728242" X-IronPort-AV: E=Sophos;i="6.21,256,1763452800"; d="scan'208";a="70728242" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 23:27:42 -0800 X-CSE-ConnectionGUID: UQ9jyd1BQsusAeiGIqBxKw== X-CSE-MsgGUID: 47IAGrLGTtqbubLNVc14vQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,256,1763452800"; d="scan'208";a="208146706" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.248]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 23:27:32 -0800 Date: Tue, 27 Jan 2026 09:27:29 +0200 From: Andy Shevchenko To: Ethan Nelson-Moore Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thangaraj Samynathan , Rengarajan Sundararajan , UNGLinuxDriver@microchip.com, Petko Manolov , Oliver Neukum , Nikita Zhandarovich , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Deepanshu Kartikey , Thomas Gleixner , Ingo Molnar , Foster Snowhill , "Gustavo A. R. Silva" , Kees Cook , Eric Biggers Subject: Re: [PATCH net-next] net: usb: switch to two-argument strscpy Message-ID: References: <20260126035052.31216-1-enelsonmoore@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jan 26, 2026 at 12:07:57PM +0200, Andy Shevchenko wrote: > On Sun, Jan 25, 2026 at 07:50:15PM -0800, Ethan Nelson-Moore wrote: > > All instances of strscpy in the USB network drivers use the size of the > > destination. If given only two arguments, strscpy will automatically > > use the size of the destination. Make the code more concise by > > switching to the two-argument form of strscpy. > > > > Also add a blank line after a variable declaration in catc.c to adhere > > to kernel code style, since the surrounding code is being touched. > > It should go after your patch that drops some of the strscpy():s. > Hence make a v3 as a series of two patches. FWIW, your v3 missed this patch... What's your plan with it? -- With Best Regards, Andy Shevchenko