From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, shenjian15@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
lantao5@huawei.com, huangdonghua3@h-partners.com,
yangshuaisong@h-partners.com, jonathan.cameron@huawei.com,
salil.mehta@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] extend bit width in the flow director of HNS3 driver
Date: Tue, 27 Jan 2026 12:53:35 +0000 [thread overview]
Message-ID: <aXi1T3WUmc0QvlN_@horms.kernel.org> (raw)
In-Reply-To: <acbfdba6-1590-417f-8bf5-f5ad44e1c294@huawei.com>
On Tue, Jan 27, 2026 at 09:50:21AM +0800, Jijie Shao wrote:
>
> on 2026/1/26 22:03, Simon Horman wrote:
> > On Fri, Jan 23, 2026 at 05:47:54PM +0800, Jijie Shao wrote:
> > > The bit widths of HCLGE_FD_AD_QID and HCLGE_FD_AD_COUNTER_NUM are
> > > increased to support higher specifications.
> > >
> > > Note: The hardware already supports the specifications.
> > Hi Jijie,
> >
> > Are there any compatibility issues here?
> > E.g. new driver with old hardware or firmware?
>
> Thank you, There are no compatibility issues.
>
> The chip and firmware are supported in V2.
> However, the software does not support the extension due to
> consistency with older versions(and the customer has not used the extended bits either).
>
> The queue_cnt and counter_cnt specifications of the software are directly
> or indirectly queried from the firmware, and the extended bits are not
> used in the V1 version.
>
Thanks, I think that addresses my concern.
The code changes themselves look good to me.
So, for the series:
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-01-27 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 9:47 [PATCH net-next 0/2] extend bit width in the flow director of HNS3 driver Jijie Shao
2026-01-23 9:47 ` [PATCH net-next 1/2] net: hns3: extend HCLGE_FD_AD_QID to 11 bits Jijie Shao
2026-01-23 9:47 ` [PATCH net-next 2/2] net: hns3: extend HCLGE_FD_AD_COUNTER_NUM to 8 bits Jijie Shao
2026-01-26 14:03 ` [PATCH net-next 0/2] extend bit width in the flow director of HNS3 driver Simon Horman
2026-01-27 1:50 ` Jijie Shao
2026-01-27 12:53 ` Simon Horman [this message]
2026-01-27 12:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXi1T3WUmc0QvlN_@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=huangdonghua3@h-partners.com \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=lantao5@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=yangshuaisong@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox