From: Simon Horman <horms@kernel.org>
To: Junjie Cao <junjie.cao@intel.com>
Cc: Shuah Khan <shuah@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] selftests: ptp: use KSFT_SKIP exit code for skip scenarios
Date: Tue, 27 Jan 2026 17:04:50 +0000 [thread overview]
Message-ID: <aXjwMrXd2i2XI7ZV@horms.kernel.org> (raw)
In-Reply-To: <20260126061532.12532-1-junjie.cao@intel.com>
On Mon, Jan 26, 2026 at 02:15:31PM +0800, Junjie Cao wrote:
> The kselftest framework defines KSFT_SKIP=4 as the standard exit code
> for skipped tests. However, phc.sh currently uses a mix of 'exit 0' and
> 'exit 1' to indicate skip conditions, which can confuse test harnesses
> and CI systems.
>
> This patch introduces ksft_skip=4 variable and unifies all skip exit
> paths to use 'exit $ksft_skip', consistent with other selftests like
> net/lib.sh and net/fib_nexthops.sh.
>
> Signed-off-by: Junjie Cao <junjie.cao@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-01-27 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 6:15 [PATCH v2 1/2] selftests: ptp: use KSFT_SKIP exit code for skip scenarios Junjie Cao
2026-01-26 6:15 ` [PATCH v2 2/2] selftests: ptp: treat unsupported PHC operations as skip Junjie Cao
2026-01-27 17:04 ` Simon Horman
2026-01-26 6:32 ` [PATCH v2 1/2] selftests: ptp: use KSFT_SKIP exit code for skip scenarios Junjie Cao
2026-01-27 17:04 ` Simon Horman [this message]
2026-01-28 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXjwMrXd2i2XI7ZV@horms.kernel.org \
--to=horms@kernel.org \
--cc=junjie.cao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox