From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A22681DF27F; Wed, 28 Jan 2026 01:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769564865; cv=none; b=lJgnGcQOxGRg7vEpYNPaNeuHpaxRK7bvELq6WpAW8vmyTTkAOQ8+XbQhM6nZPZQg2dXXbAp4qcUAJTvpNYnmbu4Hg8a67cGKXxkxjkcJOv440asWTMKXK8u9sntVjKJAqXHCSTYE5SvVQjyXYPj7SbUMS3wgLIxcftvzWLd9Jnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769564865; c=relaxed/simple; bh=fTVNm7RJn/zLdCsYOiWJcBt5708nRFKu+xaSA3n8PBQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XKPFfuFLtS72U56Dbi5SE13mbDlGLeYqrEP6i27tB+wCe6+2OYGi7CV2A65nP5JiP1Tmykw8QddgYJqT6fzt79xhhyP3Op/4hMc+TVOvwUY2f8ziyxHk2FwFpbFkknMd1APxtJ3NaH5KqZyJmWpfHmNxOWqNkwusbu0Dwmvflww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vkueh-000000003no-1wjr; Wed, 28 Jan 2026 01:47:39 +0000 Date: Wed, 28 Jan 2026 01:47:36 +0000 From: Daniel Golle To: Vladimir Oltean Cc: Hauke Mehrtens , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/3] dt-bindings: net: dsa: lantiq,gswip: reference common PHY properties Message-ID: References: <20260127132919.xsvapgqc65f44iah@skbuf> <20260127150747.lzlfzhusywluuxhs@skbuf> <20260127222508.gvky6smlrmnj3uix@skbuf> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127222508.gvky6smlrmnj3uix@skbuf> On Wed, Jan 28, 2026 at 12:25:08AM +0200, Vladimir Oltean wrote: > On Tue, Jan 27, 2026 at 10:10:58PM +0000, Daniel Golle wrote: > > Taking a step back I noticed that we need to decide this also for > > mt7530. > > > > commit bde1ae2d52ab ("net: pcs: pcs-mtk-lynxi: pass SGMIISYS OF node to PCS") > > currently doesn't pass any fwnode when creating the LynxI PCS. > > > + pcs = mtk_pcs_lynxi_create(priv->dev, NULL, regmap, > > > + MT7531_PHYA_CTRL_SIGNAL3); > > > > However, each PCS does belong to a specific switch port, and it would be > > advantegous and imho consistent to also assign the ports OF node to the > > PCS, this would allow to configure the polarities also on the MT7530 > > SerDes ports. > > mt753x_phylink_mac_select_pcs() returns either &priv->pcs[dp->index].pcs > for TRGMII or priv->ports[dp->index].sgmii_pcs for the rest. > > How would one know (generally speaking) if properties placed in the > ethernet-port node are for the SGMII PCS or for the other one? Because of the port number and a fixed assignment of possible external interface types to each port: On MT7531, port 6 is always connected to the SerDes PCS. On MT7531AE port 5 is another SerDes PCS, while on MT7531BE port 5 is (the only) (T)RGMII interface. So, just like with the MaxLinear GSW1xx port and PCS are tightly tied together.