From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AD0121E087 for ; Wed, 28 Jan 2026 21:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769635087; cv=none; b=lbA8Z2wSWCCnBJB3Qk49ISHEJcvlOcscLcU8+h7x9NOTV+Y8YuKpCTDV/ivlAQ8i/sBZ3vBJKjicnMfXhV/AFpqdL0DTChA/7Yg8e2kOvAmzH6ZonnfgJj8bifOSKoeBenEcoFjTz6/V8VEbzaPBIv9Mlxi0LaR6SC1ZOPeyAtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769635087; c=relaxed/simple; bh=kjFXNlbmAL0BO92rYrTkCSuMABiMP5ofoNy2abW+ap8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z8ObZTzjLvnBA1lYEeMVlbWreF/fUD0PNMeKTMoNgmsuoircR9jWm+FBtDX7PrRCOltEljvTcb+4y2reCTKCyELXtUl08RTylGFeonE1onY8KeeGi3b3LVEmUtJCCbTuEcUE49sOcZmaB2f5+rMZ9GDhLkWPrxvbLyJaobQHLVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=VcAbRWxC; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="VcAbRWxC" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47ee07570deso2229865e9.1 for ; Wed, 28 Jan 2026 13:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769635085; x=1770239885; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ZU7FEnl0OZQVA7ODIpy0SKJAEacHqZRjK4EaXTvPIzs=; b=VcAbRWxCx1sqsR7wsEPCek4TghMY0a1vc9GxEknZR59yeMCqkqjg1CaJoLrqOfymzc LYIMCKsdWDcGTXFFAeHuG1vHMeb1H+qG5dYzKoFl7O7O7tffhq8wkVwb943kpXJavfS0 JXZsmZ0mietseQsxHDXU+1WCIwSUXbjThkfHww+t/wfYahNCHJc0k2smjB2CrMlHRT1J oIQsBhMzeHlO8saKSiNKhXA9/h9DM4jnwQKUtbAdkzeoYpUc8uBTKgDNTO8n/XeLXBVg zwGU85oRqLdKHO38LyxQs5lZtHxrEalkUPEs9Yf3ZRzRT6Goe8iMzyZqQbtbc0i++cMy lmNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769635085; x=1770239885; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZU7FEnl0OZQVA7ODIpy0SKJAEacHqZRjK4EaXTvPIzs=; b=hIHB7RH0fNzpJsa0qUW04qieS2mvJ3Nwh0Jmi2KYSvNz/wwHyihbToG8Ch99HAJh9B OgZknZ2kZI3c4fFux+eenFwhDuqe35uy1SCEbgnvOtjf4J+JUEEPJZ4Vd1s3KpAvxnn1 HsBcUC+CtGTnManPX5vRDCxWGLfQxRRBKw6HTbSWuDtUuYoMwD2tBqKUKFAypwbhezD2 WkgZ402n5k1HOpvzAYM/BbnLL58MHgh/tK7iOfjuBV7lhZBQNa0JOx9bUGhLG1uaqCMm WT2VOAQe6YqxUDLkhAxQ3BK3azmxNUW4PugLHokzZ2DgBTmhkzNbmOR1DNrTpu1/Wkan j+bQ== X-Forwarded-Encrypted: i=1; AJvYcCWN2r4CzsznI7S76S3e0s2cIoGlZiQO7Kp7Rz+0TBesRpQzUqOHpn9hfYCBA2FMBeBFejlU628=@vger.kernel.org X-Gm-Message-State: AOJu0YxtDWqe996EDF5FAb/RFK8C9VyQIbB+aGuE4BDJ/64d5vvVTFQZ h+om1aGfN0qe1ZsPdpE5S8YCw9cr0/TV59s5ORgKtY5qnGfm5KtK6ESyDyUoq42eGXE= X-Gm-Gg: AZuq6aLhVaBrb+oB2ntYQ6ohpco9FjI25yl+eppMZbiTo6F+iyHdVjTuym/quqauXD6 RUadgNU+1z5ZFcPvVmnAw45JyWdkkrD6lvun9u0uvhoX1NOaNiIBUlzqWxQlNqnengdqdMJyGgh wv1PHMRf/+3DtamK48oVjoWzplWFDUfN5tUjERu0xn2rTm21F1mtNFmDtXcoKrXTsqgw1eS9imY XDi00jwX7h8wMqT1ggIXrCqZ4ADK8MeE2jVphpnVCcCac9wIetSj/XJP65ejqcxFVb5DEKvojxp 9jMcHLdISXxwiXCii0WSAxxCqWziEibRGufiVLWxCHwyy8U8mKxFdJrKZwCDpJDC2oQxwLigjVT mifh7b2N/Mb7/XMp5mbX8nQjE17JhTDAnxUdbrPN+BgGZCXMyEJX6yfIwM4FgYlUtkcvAW+1OZ6 o5FRjjvm2aaNEBaQZ2nQ1zIymn X-Received: by 2002:a05:600c:154c:b0:47e:e9bf:dd8a with SMTP id 5b1f17b1804b1-48069cb2fddmr85513805e9.37.1769635084662; Wed, 28 Jan 2026 13:18:04 -0800 (PST) Received: from localhost (109-81-26-156.rct.o2.cz. [109.81.26.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c515sm85708295e9.11.2026.01.28.13.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 13:18:04 -0800 (PST) Date: Wed, 28 Jan 2026 22:18:03 +0100 From: Michal Hocko To: Frederic Weisbecker Cc: LKML , Michal =?iso-8859-1?Q?Koutn=FD?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Chen Ridong , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Waiman Long , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 03/33] memcg: Prepare to protect against concurrent isolated cpuset change Message-ID: References: <20260125224541.50226-1-frederic@kernel.org> <20260125224541.50226-4-frederic@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed 28-01-26 12:27:22, Frederic Weisbecker wrote: > Le Wed, Jan 28, 2026 at 09:45:03AM +0100, Michal Hocko a écrit : > > On Tue 27-01-26 13:45:06, Frederic Weisbecker wrote: > > > Le Mon, Jan 26, 2026 at 05:41:38PM +0100, Michal Hocko a écrit : > > > > On Sun 25-01-26 23:45:10, Frederic Weisbecker wrote: > > > > > The HK_TYPE_DOMAIN housekeeping cpumask will soon be made modifiable at > > > > > runtime. In order to synchronize against memcg workqueue to make sure > > > > > that no asynchronous draining is pending or executing on a newly made > > > > > isolated CPU, target and queue a drain work under the same RCU critical > > > > > section. > > > > > > > > > > Whenever housekeeping will update the HK_TYPE_DOMAIN cpumask, a memcg > > > > > workqueue flush will also be issued in a further change to make sure > > > > > that no work remains pending after a CPU has been made isolated. > > > > > > > > > > Signed-off-by: Frederic Weisbecker > > > > > --- > > > > > mm/memcontrol.c | 21 +++++++++++++++++---- > > > > > 1 file changed, 17 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > > > index be810c1fbfc3..2289a0299331 100644 > > > > > --- a/mm/memcontrol.c > > > > > +++ b/mm/memcontrol.c > > > > > @@ -2003,6 +2003,19 @@ static bool is_memcg_drain_needed(struct memcg_stock_pcp *stock, > > > > > return flush; > > > > > } > > > > > > > > > > +static void schedule_drain_work(int cpu, struct work_struct *work) > > > > > +{ > > > > > + /* > > > > > + * Protect housekeeping cpumask read and work enqueue together > > > > > + * in the same RCU critical section so that later cpuset isolated > > > > > + * partition update only need to wait for an RCU GP and flush the > > > > > + * pending work on newly isolated CPUs. > > > > > + */ > > > > > + guard(rcu)(); > > > > > + if (!cpu_is_isolated(cpu)) > > > > > + schedule_work_on(cpu, work); > > > > > > > > Shouldn't this in the guarded rcu section? > > > > > > This is what guard(rcu)() does, right? > > > Or am I missing something? > > > > I am probably misreading the patch. But I've had the following in mind > > > > scoped_guard(rcu) { > > if (!cpu_is_isolated(cpu)) > > schedule_work_on(cpu, work); > > } > > guard(...)() protects everything that follows within the same block > (here the whole function) whereas scoped_guard only applies to the > following scope (here what is inside the {} in your example). > > So both work. I see. Thanks for the clarification. I would probably prefer a more explicit call convention but no strong opinion on that. -- Michal Hocko SUSE Labs