public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Geetha sowjanya <gakula@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
	edumazet@google.com, andrew+netdev@lunn.ch, sgoutham@marvell.com,
	sbhatta@marvell.com, hkelam@marvell.com
Subject: Re: [net-next PATCH] octeontx2-af: Workaround SQM/PSE stalls by disabling sticky
Date: Thu, 29 Jan 2026 13:09:18 +0000	[thread overview]
Message-ID: <aXtb_np52Ayf83E7@horms.kernel.org> (raw)
In-Reply-To: <20260127125147.1642-1-gakula@marvell.com>

On Tue, Jan 27, 2026 at 06:21:47PM +0530, Geetha sowjanya wrote:
> NIX SQ manager sticky mode is known to cause stalls when multiple SQs
> share an SMQ and transmit concurrently. Additionally, PSE may deadlock
> on transitions between sticky and non-sticky transmissions. There is
> also a credit drop issue observed when certain condition clocks are
> gated.
> 
> work around these hardware errata by:
> - Disabling SQM sticky operation:
>   - Clear TM6 (bit 15)
>   - Clear TM11 (bit 14)
> - Disabling sticky → non-sticky transition path that can deadlock PSE:
>   - Clear TM5 (bit 23)
> - Preventing credit drops by keeping the control-flow clock enabled:
>   - Set TM9 (bit 21)
> 
> These changes are applied via NIX_AF_SQM_DBG_CTL_STATUS. With this
> configuration the SQM/PSE maintain forward progress under load without
> credit loss, at the cost of disabling sticky optimizations.
> 
> Signed-off-by: Geetha sowjanya <gakula@marvell.com>

I didn't look over the rest of the driver, but it strikes me that the code
touched by this patch could benefit from some defines for the bits of cfg.

But I don't think that needs to block progress of this patch.

Reviewed-by: Simon Horman <horms@kernel.org>

...

  reply	other threads:[~2026-01-29 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 12:51 [net-next PATCH] octeontx2-af: Workaround SQM/PSE stalls by disabling sticky Geetha sowjanya
2026-01-29 13:09 ` Simon Horman [this message]
2026-01-30  2:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXtb_np52Ayf83E7@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox