From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Simon Horman <horms@kernel.org>,
vkoul@kernel.org, neil.armstrong@linaro.org, krzk+dt@kernel.org,
conor+dt@kernel.org, ciprianmarian.costea@oss.nxp.com,
s32@nxp.com, p.zabel@pengutronix.de, ghennadi.procopciuc@nxp.com,
bogdan-gabriel.roman@nxp.com, Ionut.Vicovan@nxp.com,
alexandru-catalin.ionita@nxp.com, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Frank.li@nxp.com
Subject: Re: [PATCH 2/4] phy: s32g: Add serdes subsystem phy
Date: Thu, 29 Jan 2026 13:23:33 +0000 [thread overview]
Message-ID: <aXtfVUb0eLwP4R28@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAKfTPtDfnpzq2CB-isVzvh1ZCWo7kit9KRJvVGoU1C3zZTgdXw@mail.gmail.com>
On Thu, Jan 29, 2026 at 02:01:13PM +0100, Vincent Guittot wrote:
> yes, the usual pattern is :
> - phy_set_mode_ext()
> - then phy_power_on()
> but I can add an additional check
Please read Documentation/driver-api/phy/phy.rst section "Order of API
calls" which suggests phy_set_mode_ext() after phy_power_on().
Having different requirements for different SerDes PHYs quickly becomes
annoying for users of the SerDes PHYs.
E.g. I'm trying to add SerDes PHY support to stmmac, which is used
across different platforms. Having all SerDes PHY drivers behave the
same as far as their PHY API calls are concerned means that the whole
point of having an abstracted interface is maintained. Otherwise, it's
completely pointless.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-01-29 13:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 9:21 [PATCH 0/4] Serdes: s32g: Add support for serdes subsystem Vincent Guittot
2026-01-26 9:21 ` [PATCH 1/4] dt-bindings: serdes: s32g: Add NXP " Vincent Guittot
2026-01-29 12:50 ` Russell King (Oracle)
2026-01-29 13:05 ` Vincent Guittot
2026-01-26 9:21 ` [PATCH 2/4] phy: s32g: Add serdes subsystem phy Vincent Guittot
2026-01-26 13:11 ` Philipp Zabel
2026-01-27 10:07 ` Vincent Guittot
2026-01-29 9:54 ` Simon Horman
2026-01-29 13:01 ` Vincent Guittot
2026-01-29 13:23 ` Russell King (Oracle) [this message]
2026-01-29 13:36 ` Vincent Guittot
2026-01-29 13:51 ` Russell King (Oracle)
2026-01-29 14:30 ` Vinod Koul
2026-01-29 14:36 ` Russell King (Oracle)
2026-01-30 14:50 ` Russell King (Oracle)
2026-01-29 11:17 ` Russell King (Oracle)
2026-01-29 13:02 ` Vincent Guittot
2026-01-26 9:21 ` [PATCH 3/4] phy: s32g: Add serdes xpcs subsystem Vincent Guittot
2026-01-29 11:59 ` Simon Horman
2026-01-29 13:24 ` Vincent Guittot
2026-01-29 16:20 ` Simon Horman
2026-01-29 12:30 ` Russell King (Oracle)
2026-01-29 13:45 ` Vincent Guittot
2026-01-26 9:21 ` [PATCH 4/4] MAINTAINERS: Add MAINTAINER for NXP S32G Serdes driver Vincent Guittot
2026-01-29 12:07 ` Simon Horman
2026-01-29 13:25 ` Vincent Guittot
2026-01-29 12:36 ` [PATCH 0/4] Serdes: s32g: Add support for serdes subsystem Russell King (Oracle)
2026-01-29 13:26 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXtfVUb0eLwP4R28@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Frank.li@nxp.com \
--cc=Ionut.Vicovan@nxp.com \
--cc=alexandru-catalin.ionita@nxp.com \
--cc=bogdan-gabriel.roman@nxp.com \
--cc=ciprianmarian.costea@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@nxp.com \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s32@nxp.com \
--cc=vincent.guittot@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox