From: Joe Damato <joe@dama.to>
To: Fan Gong <gongfan1@huawei.com>
Cc: Zhu Yikai <zhuyikai1@h-partners.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
luosifu <luosifu@huawei.com>, Xin Guo <guoxin09@huawei.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Luo Yang <luoyang82@h-partners.com>
Subject: Re: [PATCH net-next v03 1/4] hinic3: Fix code Style(remove empty lines between error handling)
Date: Thu, 29 Jan 2026 12:12:56 -0800 [thread overview]
Message-ID: <aXu/SDa0Z+w0v5zv@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <ccff2ae7abe91bb3618ded9bb5ef2dc9cb243d22.1769656467.git.zhuyikai1@h-partners.com>
On Thu, Jan 29, 2026 at 12:01:08PM +0800, Fan Gong wrote:
> According to previous review comment, fix code style of removing empty
Hm, I'm wondering if maybe the subject or commit message could be reworded a
little bit?
Maybe something simpler like:
Subject: [PATCH net-next v3 1/4] hinic3: Remove empty lines
Make error handling paths more idiomatic by removing empty lines.
Link: https://lore.kernel.org/netdev/20250902180937.4c8d9eb3@kernel.org/
Co-developed-by: ...
Signed-off-by: ...
Maybe Simon has a better suggestion.
next prev parent reply other threads:[~2026-01-29 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 4:01 [PATCH net-next v03 0/4] net: hinic3: Fix code styles Fan Gong
2026-01-29 4:01 ` [PATCH net-next v03 1/4] hinic3: Fix code Style(remove empty lines between error handling) Fan Gong
2026-01-29 20:12 ` Joe Damato [this message]
2026-01-29 4:01 ` [PATCH net-next v03 2/4] hinic3: Remove defensive txq_num check Fan Gong
2026-01-29 4:01 ` [PATCH net-next v03 3/4] hinic3: Use array_size instead of multiplying Fan Gong
2026-01-29 20:06 ` Joe Damato
2026-01-29 4:01 ` [PATCH net-next v03 4/4] hinic3: RQ use RQ_CTXT_PREF_CI_HI instead of SQ_CTXT_PREF_CI_HI Fan Gong
2026-01-30 3:00 ` [PATCH net-next v03 0/4] net: hinic3: Fix code styles patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXu/SDa0Z+w0v5zv@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=luoyang82@h-partners.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox