From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E65FD326D69; Thu, 29 Jan 2026 22:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769724055; cv=none; b=mjlr10czhk6Yzila4jCKCJRFpJ8Au7cywedtl2YRoDofCFP7g2Iwh65hEKt49Qjgxd2Q//J56Lakv0WkQLa9d6eYJ5JjEMV3dd+if9N+Eq4MlFANUehhHEAXD3m9sB4gfo4rAtD6dzNkTsaLfdjCHGTn4xwC9sHaTXLYuBx/VTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769724055; c=relaxed/simple; bh=YqNWb+uEWkjz1XXk8wLbalCffPtk4g7xZuyyJzhd2iA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NXaaz4PLtKg6nSOcfw4guB6naEy4HNlpRhhNgEV/5A7zHcGH20DpMLAsoFJ28YUC3hcXX/9HI7cUdsRs6S5Drew6bixbEhsam9nXOkQ4OS93EyEEmI68KdbZQ9wQ8NbRk2GgPMDDAYPigmX4BlyI/NwFpc5qwRn1x9hjbc7F+DE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=FuORfFkK; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="FuORfFkK" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5NaZq7/qOx5j3sYVWWAXyxivGGckilTrm3I0MWAebJ0=; b=FuORfFkKV0DQIUUuMAonHTBSMq HF2MOUM/Hc7enwPm0B5st77tQNNjf0eKU/pZo/h8uFpZk3KazeRogVT16rnuLFu4rRtaZ6WB50HuT oQloQVUjqsYNnVPMNueythTNsQumeeZJpD7lFjQuMi2kGPSSZ/2aqJe5xufgqTlMcawAYyslgphns OxxQAsBSIewVc03grwlhmNGyURyOFRkdaZLHvnAGAntQeeeLslHwVSeWeW1Nl1gP66MfK6N91OFj9 5OB/+2cFKWTslP6LNj6Kz3pKBbMrqn4RcR2kAjhsppKEXH6aexaqY+7IKQt7qE+B8ThTjVf70J7OS v6U1biyg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39260) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vla4A-000000000Va-0f2c; Thu, 29 Jan 2026 22:00:42 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vla44-000000008Kd-1QMZ; Thu, 29 Jan 2026 22:00:36 +0000 Date: Thu, 29 Jan 2026 22:00:36 +0000 From: "Russell King (Oracle)" To: Mohd Ayaan Anwar Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH net-next v2 00/14] net: stmmac: SerDes, PCS, BASE-X, and inband goodies Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Thu, Jan 29, 2026 at 12:57:05PM +0530, Mohd Ayaan Anwar wrote: > I was thinking about the "good" sequence (i.e., the current net-next > tree): > -> phylink_up > -> mac_link_up > -> fix_mac_speed > -> SerDes configured via phy_set_speed > -> stmmac_pcs_ctrl_ane(priv, enable/disable, 0) > > Please let me know if you want me to try any other experiments. > Maybe I need to do some more testing after playing around with the > sequence followed by this series? Given discussion elsewhere, it seems that the generic PHY maintainers have come to the conclusion (at my request) that the documentation is incorrect and needs to be changed: Order of API calls ================== The general order of calls should be:: [devm_][of_]phy_get() phy_init() phy_power_on() [phy_set_mode[_ext]()] ... phy_power_off() phy_exit() [[of_]phy_put()] Essentially, most users of generic PHY do not follow this, but call phy_set_mode[_ext]() before phy_power_on(). This will have implications for this patch series, particularly the serdes related changes, and will make the update to qcom-sgmii-eth more complex (as its current phy_power_on() implementation does very little and isn't the reverse of phy_power_off().) In the mean time, please test patch 2 to see whether that can be merged. I'm going to re-order some of the patches in this series to see what else can be merged without depending on that and without affecting dwmac-qcom-ethqos, and thus shrinking this series. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!